feat(net): add BAL requirement to block access list requests by 0xKarl98 · Pull Request #23682 · paradigmxyz/reth

0xKarl98 · 2026-04-22T10:58:32Z

This PR adds a BAL request requirement to the network fetch path, so callers can choose between Mandatory and Optional handling.
Mandatory preserves the existing behavior, while Optional lets the local reth node stop waiting when no connected peer can serve
BALs.

Roadmap:

validate returned BALs against the block header hash and return them as Sealed
extend the same requirement and validation flow to full-block range requests

@mattsse

mattsse

I think we should instead apply the check only once here:

reth/crates/net/network/src/fetch/mod.rs

Lines 234 to 235 in d554584

    
           match self.download_requests_rx.poll_next_unpin(cx) { 
        
               Poll::Ready(Some(request)) => match request.get_priority() {

which should be more efficient than always doing it when we select a peer

there's only a potential edge case when we drop a eth71 peer later but imo we can live with that

mattsse · 2026-04-23T07:27:13Z

    fn poll_action(&mut self) -> PollAction {
-        // we only check and not pop here since we don't know yet whether a peer is available.
-        if self.queued_requests.is_empty() {
-            return PollAction::NoRequests
-        }
+        loop {


I dont think we need to change anything here?

this is hard to review, and I think we can achieve this feature with fewer changes

0xKarl98 · 2026-04-24T03:52:50Z

@mattsse have modified according to your feedback

This reverts commit 57601ef.

mattsse

Looks good. The remaining follow-up request compatibility concern is pre-existing and can be handled separately.

Automated nightly update of reth dependencies from `paradigmxyz/reth` main branch. ## Upstream reth changes [`7839f3d...73ec2c9`](paradigmxyz/reth@7839f3d...73ec2c9) 🔗 Amp thread: https://ampcode.com/threads/T-019dd89b-f659-75eb-a3f2-3e769d63297f **Engine** - Spawn BAL hashed state before storage prefetch ([#23761](paradigmxyz/reth#23761)) and disable BAL parallel execution by default ([#23764](paradigmxyz/reth#23764)) - Add CLI flag to disable BAL storage prefetch ([#23770](paradigmxyz/reth#23770)) - Log transient invalid header cache skips ([#23711](paradigmxyz/reth#23711)) - Add `DecodedBal` in `ExecutionEnv` ([#23675](paradigmxyz/reth#23675)) **RPC** - Clean up eth state cache reorg entries ([#23683](paradigmxyz/reth#23683)) - Pass block timestamp to txn ([#23700](paradigmxyz/reth#23700)) - Include block numbers in `BlockRangeExceedsHead` error ([#23720](paradigmxyz/reth#23720)) **Network / P2P** - Add Basic in-memory BAL store and BAL request to block access list requests ([#23682](paradigmxyz/reth#23682), [#23710](paradigmxyz/reth#23710)) - Enforce BAL response soft limit and apply count cap to handler ([#23725](paradigmxyz/reth#23725), [#23754](paradigmxyz/reth#23754)) - Avoid RLP-decoding `NewBlock` payloads ([#23712](paradigmxyz/reth#23712)) and bound memory footprint of p2p messages ([#23718](paradigmxyz/reth#23718)) - Memory-bound channel between network and tx manager ([#23802](paradigmxyz/reth#23802)) - Track unknown tx types in announcement metrics ([#23688](paradigmxyz/reth#23688)) - Retain active session buffer capacity ([#23702](paradigmxyz/reth#23702)) and respect peer requirements for fetch followups ([#23706](paradigmxyz/reth#23706)) - Support binding discv5 and discv4 to the same port ([#23613](paradigmxyz/reth#23613)) and use Weak reference in discv5 kbuckets bg task to release port on shutdown ([#23282](paradigmxyz/reth#23282)) **Trie** - Skip DB seek on exact overlay hits ([#23559](paradigmxyz/reth#23559)) - Account for heap-allocated blinded hashes in `SparseNode::memory_size` ([#23726](paradigmxyz/reth#23726)) **DB / Storage** - `reth db migrate-v2` for pruned nodes ([#23716](paradigmxyz/reth#23716)) - Pass `ExecutedBlocks` to `OverlayBuilder`, reduce reverts queried ([#23657](paradigmxyz/reth#23657)) - Add empty request check to storage values ([#23714](paradigmxyz/reth#23714)) - Derive `Eq` for `IntegerList` ([#23709](paradigmxyz/reth#23709)) and reorder unix deps after strum ([#23697](paradigmxyz/reth#23697)) **Provider / EVM** - Use overlay builders in historical state paths ([#23667](paradigmxyz/reth#23667)) - Return gas output from block builder ([#23744](paradigmxyz/reth#23744)) - Expose executor transaction result type ([#23759](paradigmxyz/reth#23759)) **Perf** - Configurable rocksdb block cache size and re-use of mdbx provider in re-execute ([#23701](paradigmxyz/reth#23701)) - Enable revm `p256-aws-lc-rs` feature ([#23721](paradigmxyz/reth#23721)) - Add platform-specific RUSTFLAGS to Dockerfile ([#23738](paradigmxyz/reth#23738)) **Bench** - Add reorg mode to `new-payload-fcu` ([#23666](paradigmxyz/reth#23666)) - Enable `keccak-cache-global` in `reth-bb` ([#23723](paradigmxyz/reth#23723)) and fix multi-executor support ([#23763](paradigmxyz/reth#23763)) - Dedupe merged BAL storage reads ([#23758](paradigmxyz/reth#23758)) **Re-execute** - Verify reverts against changesets ([#23717](paradigmxyz/reth#23717)) **Payload** - Track Amsterdam block gas in builders ([#23743](paradigmxyz/reth#23743)) **CLI** - Use `TxTy`/`ReceiptTy` for static-file db get ([#23692](paradigmxyz/reth#23692)) and node types in execution stage dump ([#23705](paradigmxyz/reth#23705)) - Preserve `trusted_nodes_only` from config when `--trusted-only` is unset ([#23703](paradigmxyz/reth#23703)) - Avoid u64 underflow in `setup_without_evm` for genesis header ([#23728](paradigmxyz/reth#23728)) **Testing** - Add BAL request e2e coverage ([#23727](paradigmxyz/reth#23727)) - Cover admin node info discv5 port ([#23781](paradigmxyz/reth#23781)) **Misc** - Bump reth core to v0.3.1 ([#23707](paradigmxyz/reth#23707)) and alloy-evm to 0.33.3 ([#23778](paradigmxyz/reth#23778)) - Align ERA1 export with spec ([#23693](paradigmxyz/reth#23693)) ## Migrations 🔗 Amp thread: https://ampcode.com/threads/T-019dd89c-63d3-752f-ac22-7d4aef2ac3e3 - **Bumped reth git rev** from `7839f3d` to `73ec2c9` across all `reth-*` workspace dependencies in [Cargo.toml](file:///home/runner/work/tempo/tempo/Cargo.toml), and bumped `reth-primitives-traits` from `0.3.0` to `0.3.1` and `alloy-evm` from `0.33.0` to `0.34.0` to track upstream releases. - **Switched p2p proxy transactions channel** from `tokio::sync::mpsc::unbounded_channel` to `reth_metrics::common::mpsc::memory_bounded_channel` with a 32 MiB budget in [bin/tempo/src/p2p_proxy.rs](file:///home/runner/work/tempo/tempo/bin/tempo/src/p2p_proxy.rs), matching reth's new default `tx_channel_memory_limit_bytes` to prevent unbounded memory growth; added `reth-metrics` to [bin/tempo/Cargo.toml](file:///home/runner/work/tempo/tempo/bin/tempo/Cargo.toml). - **Changed `BlockExecutor::commit_transaction` signature** in [crates/evm/src/block.rs](file:///home/runner/work/tempo/tempo/crates/evm/src/block.rs) from returning `Result<GasOutput, BlockExecutionError>` to returning `GasOutput` directly (upstream removed the fallible return); replaced the missing-tx error with an `expect`, and updated all tests to drop `.unwrap()`. - **Added `Send + 'static` bound to `TxResult` impl** for `TempoTxResult<H>` to satisfy the new upstream trait bounds on associated execution-result types. - **Exposed `TempoBlockExecutor` and `TempoTxResult` as `pub`** (previously `pub(crate)`) and re-exported them from [crates/evm/src/lib.rs](file:///home/runner/work/tempo/tempo/crates/evm/src/lib.rs) so they can be named in the new associated types. - **Added associated types `TxExecutionResult` and `Executor` to `BlockExecutorFactory` impl** for `TempoEvmConfig`, and changed `create_executor` to return the concrete `Self::Executor<'a, DB, I>` instead of `impl BlockExecutorFor<'a, Self, DB, I>`, tracking upstream's move from RPIT to named associated types; dropped the now-unused `BlockExecutorFor` import and the `'a` lifetime bounds on `DB`/`I`. - **Implemented new `HeaderMut` methods** (`set_mix_hash`, `set_extra_data`, `set_parent_beacon_block_root`) for `TempoHeader` in [crates/primitives/src/reth_compat/header.rs](file:///home/runner/work/tempo/tempo/crates/primitives/src/reth_compat/header.rs) to satisfy the expanded upstream trait, delegating to the inner Ethereum header. [GitHub Workflow](https://github.com/tempoxyz/tempo/actions/runs/25101489247) --------- Co-authored-by: Centaur AI <ai@centaur.local> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: klkvr <klkvrr@gmail.com>

feat(net): add BAL requirement to block access list requests

3d6d272

0xKarl98 requested review from Rjected and mattsse as code owners April 22, 2026 10:58

github-project-automation Bot added this to Reth Tracker Apr 22, 2026

github-project-automation Bot moved this to Backlog in Reth Tracker Apr 22, 2026

mattsse requested changes Apr 23, 2026

View reviewed changes

github-project-automation Bot moved this from Backlog to In Progress in Reth Tracker Apr 23, 2026

feat(net): reject optional BAL at ingress

695b99e

0xKarl98 marked this pull request as draft April 24, 2026 01:51

0xKarl98 added 2 commits April 24, 2026 10:14

fix(net): remove never_loop in fetch poll_action

a7f6ca4

rename

abbb7e1

0xKarl98 requested a review from mattsse April 24, 2026 03:40

0xKarl98 marked this pull request as ready for review April 24, 2026 03:40

mattsse added 7 commits April 24, 2026 10:03

fix(net): handle optional BAL queue edge cases

57601ef

Revert "fix(net): handle optional BAL queue edge cases"

2dd8642

This reverts commit 57601ef.

fix(net): restore fetch queue comments

22de11b

refactor(net): add peer requirement helper

f7fd967

refactor(net): add optional BAL request helper

46e33d4

docs(net): explain optional BAL peer check

f827ae6

fix(net): reject queued optional BAL without eth71

05fc488

mattsse approved these changes Apr 24, 2026

View reviewed changes

Merge branch 'main' into feat/FullBlockClient

5c57098

mattsse enabled auto-merge April 24, 2026 08:23

mattsse added this pull request to the merge queue Apr 24, 2026

Merged via the queue into paradigmxyz:main with commit cf6ffb1 Apr 24, 2026
34 checks passed

github-project-automation Bot moved this from In Progress to Done in Reth Tracker Apr 24, 2026

decofe mentioned this pull request Apr 25, 2026

deps: update reth from main (2026-04-29) tempoxyz/tempo#3714

Merged

0xKarl98 deleted the feat/FullBlockClient branch April 25, 2026 12:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(net): add BAL requirement to block access list requests#23682

feat(net): add BAL requirement to block access list requests#23682
mattsse merged 12 commits into
paradigmxyz:mainfrom
0xKarl98:feat/FullBlockClient

0xKarl98 commented Apr 22, 2026

Uh oh!

mattsse left a comment

Uh oh!

mattsse Apr 23, 2026

Uh oh!

Uh oh!

0xKarl98 commented Apr 24, 2026

Uh oh!

mattsse left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	match self.download_requests_rx.poll_next_unpin(cx) {
	Poll::Ready(Some(request)) => match request.get_priority() {

Conversation

0xKarl98 commented Apr 22, 2026

Uh oh!

mattsse left a comment

Choose a reason for hiding this comment

Uh oh!

mattsse Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

0xKarl98 commented Apr 24, 2026

Uh oh!

mattsse left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants