feat(trie): remove `SerialSparseTrie` by DaniPopes · Pull Request #21808 · paradigmxyz/reth

DaniPopes · 2026-02-04T14:24:22Z

Summary

Remove SerialSparseTrie and make ParallelSparseTrie the only sparse trie implementation.

Background

ParallelSparseTrie has been the default and only used implementation in production since:

Aug 2025: Enabled by default for account tries (perf(trie): default ParallelSparseTrie to enabled (accounts only still) #17956)
Sep 2025: Extended to storage tries (perf(trie): Use ParallelSparseTrie (if enabled) for storage tries #17959)

The --disable-parallel-sparse-trie flag was kept for fallback, but SerialSparseTrie has been effectively dead code.

Changes

Remove SerialSparseTrie from reth-trie-sparse
Move ParallelSparseTrie from reth-trie-sparse-parallel into reth-trie-sparse
Delete reth-trie-sparse-parallel crate
Update SparseStateTrie default type parameter to ParallelSparseTrie
Remove sparse trie benchmarks (were comparing serial vs parallel)
Update tests to use find_leaf() instead of nodes_ref() (internal API not exposed by ParallelSparseTrie)

Simplifications

One less crate to maintain
No more feature flag complexity for parallel trie selection
Clearer code path in engine tree

…default

codspeed-hq · 2026-02-04T15:44:01Z

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing dani/nuke-serial-sparse-trie (230cdde) with main (3668575)}

Summary

✅ 70 untouched benchmarks
⏩ 55 skipped benchmarks¹

55 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

…v dep Amp-Thread-ID: https://ampcode.com/threads/T-019c29b1-1af6-776d-bb1c-16937cc6e4f0 Co-authored-by: Amp <amp@ampcode.com>

Amp-Thread-ID: https://ampcode.com/threads/T-019c29b1-1af6-776d-bb1c-16937cc6e4f0 Co-authored-by: Amp <amp@ampcode.com>

…f in tests

mattsse

rip bozo

mattsse · 2026-02-04T23:04:20Z

crates/engine/tree/src/tree/payload_processor/sparse_trie.rs


 /// Sparse trie task implementation that uses in-memory sparse trie data to schedule proof fetching.
-pub(super) struct SparseTrieCacheTask<A = SerialSparseTrie, S = SerialSparseTrie> {
+pub(super) struct SparseTrieCacheTask<A = ParallelSparseTrie, S = ParallelSparseTrie> {


maybe we dont actually need these anymore, but can keep for now

DaniPopes · 2026-02-05T12:44:01Z

will do rename and cleanup in a followup so that this one is actually reviewable

…igmxyz/reth into dani/nuke-serial-sparse-trie

- Restored ParallelSparseTrie to match pst-reveal-leaf-fix branch (with import adaptations for new location) - Removed sparse_trie_fuzz_vs_serial test that relied on SerialSparseTrie

…gmxyz/reth into dani/nuke-serial-sparse-trie

…se-trie

github-actions · 2026-02-09T12:00:08Z

✅ Changelog found on PR.

Edit changelog

…se-trie

…/reth into dani/nuke-serial-sparse-trie

Amp-Thread-ID: https://ampcode.com/threads/T-019c4230-da85-7352-9728-6d2737195eea Co-authored-by: Amp <amp@ampcode.com>

…n reth-trie-sparse

* paradigmxyz/main: (144 commits) feat(engine): add getPayloadBodiesV2 endpoints for EIP-7928 BAL support (paradigmxyz#21774) ci: skip scheduled workflows on forks (paradigmxyz#22022) chore: rm random log file (paradigmxyz#22023) chore: remove base.reth.rs public endpoint references (paradigmxyz#22019) feat(rpc): add `subscribeFinalizedChainNotifications` endpoint (paradigmxyz#22011) feat(trie): remove `SerialSparseTrie` (paradigmxyz#21808) fix(rocksdb): set max_open_files to prevent fd exhaustion (paradigmxyz#22005) refactor(txpool): rename and document validation methods (paradigmxyz#22008) feat(engine): prefetch withdrawal addresses in pre-warming (paradigmxyz#21966) refactor(pool): add IntoIter: Send bounds to avoid unnecessary Vec collect (paradigmxyz#22001) fix(rpc): enforce blockHash constraint in append_matching_block_logs (paradigmxyz#22007) chore: move Kurtosis failures to the hive slack channel (paradigmxyz#21983) feat(rpc): propagate TransactionOrigin through send_transaction and batcher (paradigmxyz#21969) feat(engine): reorg depth commitment metric (paradigmxyz#21992) feat(storage): add use_hashed_state storage setting (paradigmxyz#21997) perf: better scheduling for storage roots computation (paradigmxyz#21987) chore(deps): bump alloy 1.6.2 -> 1.6.3 (paradigmxyz#21986) fix(stages): skip sender unwind when fully pruned (paradigmxyz#21988) chore(net): remove OP stack bootnodes (paradigmxyz#21984) ci: use depot for hive and kurtosis image builds, run daily (paradigmxyz#21976) ... # Conflicts: # .github/workflows/compact.yml # .github/workflows/dependencies.yml # .github/workflows/docker-tag-latest.yml # .github/workflows/docker.yml # .github/workflows/e2e.yml # .github/workflows/hive.yml # .github/workflows/integration.yml # .github/workflows/kurtosis.yml # .github/workflows/lint.yml # .github/workflows/release.yml # .github/workflows/reproducible-build.yml # .github/workflows/stale.yml # .github/workflows/sync-era.yml # .github/workflows/sync.yml # .github/workflows/unit.yml # bin/reth/Cargo.toml # crates/cli/commands/src/node.rs # crates/node/core/src/node_config.rs

DaniPopes requested review from Rjected, gakonst, mattsse, mediocregopher, shekhirin and yongkangc as code owners February 4, 2026 14:24

github-project-automation bot added this to Reth Tracker Feb 4, 2026

github-project-automation bot moved this to Backlog in Reth Tracker Feb 4, 2026

DaniPopes force-pushed the dani/nuke-serial-sparse-trie branch from a36fba4 to 89cc006 Compare February 4, 2026 15:03

feat(trie): remove SerialSparseTrie, make ParallelSparseTrie the …

40203c0

…default

DaniPopes force-pushed the dani/nuke-serial-sparse-trie branch from 89cc006 to 40203c0 Compare February 4, 2026 15:36

DaniPopes and others added 12 commits February 4, 2026 16:58

ParallelSparseTrie as default

8829818

chore: clippy

606c24f

fix: restore private visibility for internal structs in state.rs

601e02a

fix: add missing alloc imports for no_std builds and remove unused de…

db8f876

…v dep Amp-Thread-ID: https://ampcode.com/threads/T-019c29b1-1af6-776d-bb1c-16937cc6e4f0 Co-authored-by: Amp <amp@ampcode.com>

chore: revert benchmark changes

12615e1

Amp-Thread-ID: https://ampcode.com/threads/T-019c29b1-1af6-776d-bb1c-16937cc6e4f0 Co-authored-by: Amp <amp@ampcode.com>

fix: minimal changes for state.rs - use find_leaf instead of nodes_re…

460b212

…f in tests

chore: remove sparse trie benchmarks

3188042

nit

c32a94e

Merge origin/main

ff70e17

chore: remove unused criterion dev-dependency

39aa733

nits

e9322fb

fix: test failure

e00e2d7

mattsse approved these changes Feb 4, 2026

View reviewed changes

github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Feb 4, 2026

Rjected mentioned this pull request Feb 6, 2026

fix(trie): cleanup branch_node_masks on reveal_node failure #21913

Closed

mediocregopher added 2 commits February 6, 2026 23:52

fix(trie): Do not reveal disconnected leaves

86959ae

Create eager-mules-fold.md

5d09f8e

mediocregopher and others added 10 commits February 7, 2026 00:17

Tracing

1efaaa8

Reveal embedded children after inserting revealed branch

afa3b6e

also check that the leaf full key hasn't been set in values

2369311

chore(trie): Spans and traces for sparse trie

fba782a

Merge branch 'mediocregopher/pst-reveal-leaf-fix' of github.com:parad…

782cdd1

…igmxyz/reth into dani/nuke-serial-sparse-trie

Create evil-pigs-cry.md

e123377

fix: drop span before processing account leaf updates

e7c67cd

fix: revert ParallelSparseTrie changes and remove SerialSparseTrie test

d1037fd

- Restored ParallelSparseTrie to match pst-reveal-leaf-fix branch (with import adaptations for new location) - Removed sparse_trie_fuzz_vs_serial test that relied on SerialSparseTrie

Merge branch 'mediocregopher/sparse-trie-traces' of github.com:paradi…

e77eec4

…gmxyz/reth into dani/nuke-serial-sparse-trie

Merge remote-tracking branch 'origin/main' into dani/nuke-serial-spar…

83cbdc4

…se-trie

mediocregopher and others added 8 commits February 9, 2026 12:04

Merge remote-tracking branch 'origin/main' into dani/nuke-serial-spar…

fa56e59

…se-trie

Merge branch 'dani/nuke-serial-sparse-trie' of github.com:paradigmxyz…

8d029af

…/reth into dani/nuke-serial-sparse-trie

fix: correct ChangedSubtrie import path in tests

33f6321

chore: retrigger CI

17f732a

Amp-Thread-ID: https://ampcode.com/threads/T-019c4230-da85-7352-9728-6d2737195eea Co-authored-by: Amp <amp@ampcode.com>

Remove accidentally committed files

d0f0ed1

fix correctly_decodes_branch_node_values

5aea435

Merge origin/main: remove SerialSparseTrie, keep ParallelSparseTrie i…

d8c7c42

…n reth-trie-sparse

chore: add changelog entry for SerialSparseTrie removal

230cdde

mediocregopher added this pull request to the merge queue Feb 10, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 10, 2026

mediocregopher added this pull request to the merge queue Feb 10, 2026

Merged via the queue into main with commit c727c61 Feb 10, 2026
41 checks passed

mediocregopher deleted the dani/nuke-serial-sparse-trie branch February 10, 2026 13:58

github-project-automation bot moved this from In Progress to Done in Reth Tracker Feb 10, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(trie): remove `SerialSparseTrie`#21808

feat(trie): remove `SerialSparseTrie`#21808
mediocregopher merged 33 commits intomainfrom
dani/nuke-serial-sparse-trie

DaniPopes commented Feb 4, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Feb 4, 2026 •

edited

Loading

Uh oh!

mattsse left a comment

Uh oh!

mattsse Feb 4, 2026

Uh oh!

DaniPopes commented Feb 5, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

DaniPopes commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Background

Changes

Simplifications

Uh oh!

codspeed-hq bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging this PR will not alter performance

Summary

Footnotes

Uh oh!

mattsse left a comment

Choose a reason for hiding this comment

Uh oh!

mattsse Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

DaniPopes commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Changelog found on PR.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

DaniPopes commented Feb 4, 2026 •

edited

Loading

codspeed-hq bot commented Feb 4, 2026 •

edited

Loading

DaniPopes commented Feb 5, 2026 •

edited

Loading

github-actions bot commented Feb 9, 2026 •

edited

Loading