refactor(txpool): rename and document validation methods#22008
Merged
Conversation
Rename internal validation methods for clarity: - validate_one_no_state -> validate_stateless - validate_one_against_state -> validate_stateful Make both public and add detailed documentation. The existing public validate_one_with_state_provider is kept unchanged with improved docs linking to the new method names. Amp-Thread-ID: https://ampcode.com/threads/T-019c445e-1f52-779f-9bc3-49fca369bc1d Co-authored-by: Amp <amp@ampcode.com>
mattsse
added
C-docs
Contributor
✅ Changelog found on PR. |
Renamed validation methods for clarity and updated documentation.
emmajam
approved these changes
Feb 9, 2026
CarlBeek
added a commit
to CarlBeek/reth
that referenced
this pull request
Feb 10, 2026
* paradigmxyz/main: (144 commits) feat(engine): add getPayloadBodiesV2 endpoints for EIP-7928 BAL support (paradigmxyz#21774) ci: skip scheduled workflows on forks (paradigmxyz#22022) chore: rm random log file (paradigmxyz#22023) chore: remove base.reth.rs public endpoint references (paradigmxyz#22019) feat(rpc): add `subscribeFinalizedChainNotifications` endpoint (paradigmxyz#22011) feat(trie): remove `SerialSparseTrie` (paradigmxyz#21808) fix(rocksdb): set max_open_files to prevent fd exhaustion (paradigmxyz#22005) refactor(txpool): rename and document validation methods (paradigmxyz#22008) feat(engine): prefetch withdrawal addresses in pre-warming (paradigmxyz#21966) refactor(pool): add IntoIter: Send bounds to avoid unnecessary Vec collect (paradigmxyz#22001) fix(rpc): enforce blockHash constraint in append_matching_block_logs (paradigmxyz#22007) chore: move Kurtosis failures to the hive slack channel (paradigmxyz#21983) feat(rpc): propagate TransactionOrigin through send_transaction and batcher (paradigmxyz#21969) feat(engine): reorg depth commitment metric (paradigmxyz#21992) feat(storage): add use_hashed_state storage setting (paradigmxyz#21997) perf: better scheduling for storage roots computation (paradigmxyz#21987) chore(deps): bump alloy 1.6.2 -> 1.6.3 (paradigmxyz#21986) fix(stages): skip sender unwind when fully pruned (paradigmxyz#21988) chore(net): remove OP stack bootnodes (paradigmxyz#21984) ci: use depot for hive and kurtosis image builds, run daily (paradigmxyz#21976) ... # Conflicts: # .github/workflows/compact.yml # .github/workflows/dependencies.yml # .github/workflows/docker-tag-latest.yml # .github/workflows/docker.yml # .github/workflows/e2e.yml # .github/workflows/hive.yml # .github/workflows/integration.yml # .github/workflows/kurtosis.yml # .github/workflows/lint.yml # .github/workflows/release.yml # .github/workflows/reproducible-build.yml # .github/workflows/stale.yml # .github/workflows/sync-era.yml # .github/workflows/sync.yml # .github/workflows/unit.yml # bin/reth/Cargo.toml # crates/cli/commands/src/node.rs # crates/node/core/src/node_config.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename internal validation methods for clarity:
validate_one_no_state→validate_stateless(now public)validate_one_against_state→validate_stateful(now public)Both methods get detailed documentation. The existing public
validate_one_with_state_provideris kept unchanged with improved docs linking to the new method names.