fix(trie): cleanup branch_node_masks on reveal_node failure#21913
Closed
gancerlory wants to merge 1 commit intoparadigmxyz:mainfrom
Closed
fix(trie): cleanup branch_node_masks on reveal_node failure#21913gancerlory wants to merge 1 commit intoparadigmxyz:mainfrom
gancerlory wants to merge 1 commit intoparadigmxyz:mainfrom
Conversation
gancerlory
requested review from
Rjected,
mediocregopher,
shekhirin and
yongkangc
as code owners
Member
|
we're actually going to remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SerialSparseTrie::reveal_nodeinserts intobranch_node_masksat the start of the method, but if any subsequent operation fails (likereveal_node_or_hashor node type conflicts), the method returns early without cleaning up. This leaves the trie in an inconsistent state.Fixed by tracking whether we inserted new masks and removing them on error.
-Extract core logic into reveal_node_inner
-Add rollback for branch_node_masks on error