fix(prune): migrate invalid bodies_history config to Distance(64)#21683
Closed
HuberyJulianay wants to merge 1 commit intoparadigmxyz:mainfrom
Closed
fix(prune): migrate invalid bodies_history config to Distance(64)#21683HuberyJulianay wants to merge 1 commit intoparadigmxyz:mainfrom
HuberyJulianay wants to merge 1 commit intoparadigmxyz:mainfrom
Conversation
github-actions
bot
added
the
S-stale
Member
|
Hey! We're doing some spring cleaning on our PR backlog 🧹 Closing old PRs to keep things tidy. If this is still relevant, please feel free to re-open — we appreciate your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend migrate() from #21677 to also fix invalid bodies_history configurations at startup. Both receipts and bodies_history have MINIMUM_DISTANCE (64) constraint as defined in PruneSegment::min_blocks()."
I think this is not low value? BTW some of my rocksDB contribution has been hold for a while like #20851 #21365 #21535, couple of the times I really trying to help but not get review and when they finally got review seems all my work overlap with some new merged commit and be closed really frustrated..