Skip to content

fix(prune): migrate invalid receipts prune config to Distance(64)#21677

Merged
joshieDo merged 1 commit intomainfrom
joshie/fix-prune-config-validation
Feb 1, 2026
Merged

fix(prune): migrate invalid receipts prune config to Distance(64)#21677
joshieDo merged 1 commit intomainfrom
joshie/fix-prune-config-validation

Conversation

@gakonst
Copy link
Member

@gakonst gakonst commented Feb 1, 2026

Updates minimal_prune_modes.receipts from Full to Distance(MINIMUM_DISTANCE).

Extends migrate() to convert invalid receipts configs (Full or Distance < 64) to Distance(64) at startup. Migrated config is persisted to reth.toml.

@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Feb 1, 2026
@gakonst gakonst force-pushed the joshie/fix-prune-config-validation branch 4 times, most recently from f97f5f7 to 27e110a Compare February 1, 2026 19:07
@gakonst gakonst changed the title fix(prune): validate receipts and bodies_history against min_blocks fix(prune): migrate invalid receipts/bodies_history configs to Distance(64) Feb 1, 2026
@gakonst gakonst force-pushed the joshie/fix-prune-config-validation branch from 27e110a to 545c4bd Compare February 1, 2026 19:16
@gakonst gakonst changed the title fix(prune): migrate invalid receipts/bodies_history configs to Distance(64) fix(prune): use correct min_blocks for receipts/bodies_history Feb 1, 2026
@gakonst gakonst force-pushed the joshie/fix-prune-config-validation branch from 545c4bd to 63e6af5 Compare February 1, 2026 19:22
@gakonst gakonst force-pushed the joshie/fix-prune-config-validation branch from ee2ed5b to 1a764c8 Compare February 1, 2026 19:25
@gakonst gakonst changed the title fix(prune): use correct min_blocks for receipts/bodies_history fix(prune): use correct min_blocks for receipts Feb 1, 2026
sender_recovery: Some(PruneMode::Full),
transaction_lookup: Some(PruneMode::Full),
receipts: Some(PruneMode::Full),
receipts: Some(PruneMode::Distance(MINIMUM_DISTANCE)),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive by: #21520 (comment)

@joshieDo joshieDo marked this pull request as ready for review February 1, 2026 19:27
@gakonst gakonst changed the title fix(prune): use correct min_blocks for receipts fix(prune): migrate invalid receipts prune config to Distance(64) Feb 1, 2026
- Update minimal_prune_modes to use Distance(MINIMUM_DISTANCE) instead
  of Full for receipts
- Extend migrate() to fix existing invalid configs at startup

Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019c1a83-84fa-76ef-b4b6-f6e22a40b1ce
@gakonst gakonst force-pushed the joshie/fix-prune-config-validation branch from 1a764c8 to 25a26fd Compare February 1, 2026 19:30
@joshieDo joshieDo enabled auto-merge February 1, 2026 19:31
@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Feb 1, 2026
@joshieDo joshieDo added this pull request to the merge queue Feb 1, 2026
Merged via the queue into main with commit 83364aa Feb 1, 2026
47 checks passed
@joshieDo joshieDo deleted the joshie/fix-prune-config-validation branch February 1, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants