feat: add destination helpers for RocksDB tables in EitherWriter#20851
Closed
HuberyJulianay wants to merge 4 commits intoparadigmxyz:mainfrom
Closed
feat: add destination helpers for RocksDB tables in EitherWriter#20851HuberyJulianay wants to merge 4 commits intoparadigmxyz:mainfrom
HuberyJulianay wants to merge 4 commits intoparadigmxyz:mainfrom
Conversation
HuberyJulianay
requested review from
joshieDo,
rakita and
shekhirin
as code owners
Contributor
Author
|
@joshieDo Hi the CI failed may caused by the network issue? |
github-actions
bot
added
the
S-stale
Contributor
Author
Member
|
Hey! We're doing some spring cleaning on our PR backlog 🧹 Closing old PRs to keep things tidy. If this is still relevant, please feel free to re-open — we appreciate your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the missing destination helpers for RocksDB tables to match the existing
senders()pattern, removes the duplicated conditional logic from thenew_*()methods and makes storage routing easier to maintain.BTW Im interested in rocksDB related task, mind shortly introducing where are we now about rocksDB?