fix: use full storage settings in init_genesis#21256
Closed
HuberyJulianay wants to merge 1 commit intoparadigmxyz:mainfrom
Closed
fix: use full storage settings in init_genesis#21256HuberyJulianay wants to merge 1 commit intoparadigmxyz:mainfrom
HuberyJulianay wants to merge 1 commit intoparadigmxyz:mainfrom
Conversation
HuberyJulianay
requested review from
Rjected,
klkvr and
mattsse
as code owners
Collaborator
|
sorry, this one is already being taken care of in #21225 - which also should ensure that building with feature edge sets the correct defaults in the CLI: https://github.com/paradigmxyz/reth/pull/21225/files |
Contributor
Author
@joshieDo Aha pity. BTW would you plz check this one? hold for a while #20851 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
init_genesis was only using
static_files.to_settings()which ignored all the rocksdb CLI flags like--rocksdb.tx-hash, causing user config to be ignored during genesis initialization. switched tostorage_settings()which properly combines both static files and rocksdb settings.