Skip to content

feat: Remove associated type consensus error#543

Merged
emhane merged 13 commits intoop-rs:unstablefrom
JoshdfG:remove-associated-type-consensus-error
Jan 6, 2026
Merged

feat: Remove associated type consensus error#543
emhane merged 13 commits intoop-rs:unstablefrom
JoshdfG:remove-associated-type-consensus-error

Conversation

@JoshdfG
Copy link

@JoshdfG JoshdfG commented Jan 5, 2026

Closes #519

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

❌ Patch coverage is 51.72414% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.22%. Comparing base (957e70c) to head (08c7738).
⚠️ Report is 3 commits behind head on unstable.

Files with missing lines Patch % Lines
crates/net/downloaders/src/file_client.rs 0.00% 3 Missing ⚠️
crates/cli/commands/src/stage/dump/execution.rs 0.00% 2 Missing ⚠️
crates/cli/commands/src/stage/dump/merkle.rs 0.00% 2 Missing ⚠️
crates/consensus/consensus/src/noop.rs 0.00% 2 Missing ⚠️
crates/cli/commands/src/import_core.rs 0.00% 1 Missing ⚠️
crates/net/downloaders/src/bodies/queue.rs 0.00% 1 Missing ⚠️
crates/net/downloaders/src/bodies/request.rs 0.00% 1 Missing ⚠️
crates/rpc/rpc/src/validation.rs 0.00% 1 Missing ⚠️
crates/stages/stages/src/stages/execution.rs 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/consensus/consensus/src/lib.rs 0.00% <ø> (ø)
crates/engine/service/src/service.rs 100.00% <100.00%> (ø)
crates/engine/tree/src/download.rs 21.25% <100.00%> (ø)
crates/engine/tree/src/tree/mod.rs 50.51% <100.00%> (+0.06%) ⬆️
crates/engine/tree/src/tree/payload_validator.rs 66.11% <100.00%> (ø)
crates/net/downloaders/src/bodies/bodies.rs 28.57% <100.00%> (ø)
crates/net/downloaders/src/bodies/task.rs 42.85% <ø> (ø)
crates/net/p2p/src/full_block.rs 0.98% <100.00%> (-0.97%) ⬇️
crates/node/builder/src/components/builder.rs 54.88% <ø> (ø)
crates/node/builder/src/components/consensus.rs 0.00% <ø> (ø)
... and 15 more

... and 36 files with indirect coverage changes

Flag Coverage Δ
e2e 35.67% <51.72%> (+0.20%) ⬆️
unit 26.73% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 53.14% <ø> (ø)
op historical proof 89.97% <ø> (+0.03%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshdfG JoshdfG force-pushed the remove-associated-type-consensus-error branch from 306b69a to 9921aff Compare January 5, 2026 03:10
@JoshdfG JoshdfG changed the title Remove associated type consensus error feat: Remove associated type consensus error Jan 5, 2026
@emhane emhane requested a review from op-will as a code owner January 5, 2026 11:43
@emhane emhane force-pushed the remove-associated-type-consensus-error branch from 9921aff to c1cd11d Compare January 5, 2026 11:51
Copy link

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bunch of unrelated semicolon additions need to be reverted, otherwise lgtm

@JoshdfG JoshdfG closed this Jan 5, 2026
@JoshdfG JoshdfG force-pushed the remove-associated-type-consensus-error branch from c1cd11d to 856c98d Compare January 5, 2026 12:32
@JoshdfG JoshdfG reopened this Jan 5, 2026
@JoshdfG JoshdfG requested a review from emhane January 5, 2026 12:40
Copy link

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls remove all the random semicolons that were added in this pr. viewing the Files Changed of the pr in the browser in Github helps to see the diff clearer, and should be possible to identify all the occurrences of this random added semicolon and remove them.

@JoshdfG JoshdfG requested a review from emhane January 5, 2026 13:39
@JoshdfG
Copy link
Author

JoshdfG commented Jan 5, 2026

pls remove all the random semicolons that were added in this pr. viewing the Files Changed of the pr in the browser in Github helps to see the diff clearer, and should be possible to identify all the occurrences of this random added semicolon and remove them.

It has all been fixed, sorry about that, the cargo +nightly fmt didn't work had to do it manually from the browser.

@emhane
Copy link

emhane commented Jan 5, 2026

pls remove all the random semicolons that were added in this pr. viewing the Files Changed of the pr in the browser in Github helps to see the diff clearer, and should be possible to identify all the occurrences of this random added semicolon and remove them.

It has all been fixed, sorry about that, the cargo +nightly fmt didn't work had to do it manually from the browser.

$ rustup toolchain install nightly

@JoshdfG JoshdfG requested a review from emhane January 5, 2026 15:08
@emhane emhane enabled auto-merge January 6, 2026 08:43
@emhane emhane added this pull request to the merge queue Jan 6, 2026
Merged via the queue into op-rs:unstable with commit 69f6061 Jan 6, 2026
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rm associated type Consensus::Error

2 participants