Skip to content

feat(trie): Merge trie changesets changes into main#19068

Merged
mediocregopher merged 22 commits intomainfrom
18460-trie-changesets
Oct 16, 2025
Merged

feat(trie): Merge trie changesets changes into main#19068
mediocregopher merged 22 commits intomainfrom
18460-trie-changesets

Conversation

@mediocregopher
Copy link
Member

This is a PR to merge the 18460-trie-changesets branch into main. This branch contains all changes implemented for #18460 which have not yet been merged into main, namely those creating and which depend on the new AccountsTrieChangeSets and StoragesTrieChangesets tables.

mediocregopher and others added 22 commits September 19, 2025 15:23
Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com>
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
Copy link
Member

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

legendary

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Oct 16, 2025
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yuge!

Comment on lines -34 to -35
#[error("Missing ancestor with hash {0}")]
MissingAncestor(B256),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!!!!

Comment on lines +7 to +8
/// NOTE new variants must be added to the end of this enum. The variant index is encoded directly
/// when writing to the `PruneCheckpoint` table, so changing the order here will corrupt the table.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good comment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Learned it the hard way 🤦

@mattsse mattsse added C-perf A change motivated by improving speed, memory usage or disk footprint A-db Related to the database labels Oct 16, 2025
@mediocregopher mediocregopher added this pull request to the merge queue Oct 16, 2025
Merged via the queue into main with commit be94d0d Oct 16, 2025
42 of 43 checks passed
@mediocregopher mediocregopher deleted the 18460-trie-changesets branch October 16, 2025 10:21
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Oct 16, 2025
emhane pushed a commit to op-rs/op-reth that referenced this pull request Oct 20, 2025
Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com>
Co-authored-by: Roman Hodulák <roman.hodulak@polyglot-software.com>
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
emhane pushed a commit to op-rs/op-reth that referenced this pull request Oct 20, 2025
Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com>
Co-authored-by: Roman Hodulák <roman.hodulak@polyglot-software.com>
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 22, 2026
…#19068)

Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com>
Co-authored-by: Roman Hodulák <roman.hodulak@polyglot-software.com>
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Feb 11, 2026
…#19068)

Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com>
Co-authored-by: Roman Hodulák <roman.hodulak@polyglot-software.com>
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-db Related to the database C-perf A change motivated by improving speed, memory usage or disk footprint

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants