Skip to content

feat(db): AccountsTrieChangeSets and StoragesTrieChangeSets tables#18503

Merged
mediocregopher merged 4 commits into18460-trie-changesetsfrom
mediocregopher/18461-trie-changesets-tables
Sep 19, 2025
Merged

feat(db): AccountsTrieChangeSets and StoragesTrieChangeSets tables#18503
mediocregopher merged 4 commits into18460-trie-changesetsfrom
mediocregopher/18461-trie-changesets-tables

Conversation

@mediocregopher
Copy link
Member

@mediocregopher mediocregopher commented Sep 16, 2025

These tables are structured similarly to their Accounts/StoragesChangeSets counterparts. They will be used to store the values of trie nodes prior to a block being processed.

Closes #18461

These tables are structured similarly to their
Accounts/StoragesChangeSets counterparts. They will be used to store
the values of trie nodes prior to a block being processed.
@mediocregopher mediocregopher force-pushed the mediocregopher/18461-trie-changesets-tables branch from 5f75411 to 4f5872e Compare September 17, 2025 10:18
@mediocregopher mediocregopher changed the title WIP feat(db): AccountsTrieChangeSets and StoragesTrieChangeSets tables Sep 17, 2025
@mediocregopher mediocregopher marked this pull request as ready for review September 17, 2025 10:19
@mediocregopher mediocregopher added C-enhancement New feature or request A-db Related to the database A-trie Related to Merkle Patricia Trie implementation labels Sep 17, 2025
@mediocregopher mediocregopher changed the base branch from main to 18460-trie-changesets September 17, 2025 10:29
@mediocregopher
Copy link
Member Author

This needs to be modified, the storages table needs the node path as part of the value.

@mediocregopher mediocregopher marked this pull request as draft September 17, 2025 14:30
@mediocregopher mediocregopher marked this pull request as ready for review September 18, 2025 10:51
@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Sep 18, 2025
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mediocregopher mediocregopher merged commit 8bfd104 into 18460-trie-changesets Sep 19, 2025
37 checks passed
@mediocregopher mediocregopher deleted the mediocregopher/18461-trie-changesets-tables branch September 19, 2025 13:23
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Sep 19, 2025
@jenpaff jenpaff moved this from Done to Completed in Reth Tracker Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-db Related to the database A-trie Related to Merkle Patricia Trie implementation C-enhancement New feature or request

Projects

Status: Completed

Development

Successfully merging this pull request may close these issues.

Trie ChangeSets: Create tables

3 participants