fix(trie): Fixes to pruning of MerkleChangeSets#18973
Merged
mediocregopher merged 7 commits into18460-trie-changesetsfrom Oct 14, 2025
Merged
fix(trie): Fixes to pruning of MerkleChangeSets#18973mediocregopher merged 7 commits into18460-trie-changesetsfrom
mediocregopher merged 7 commits into18460-trie-changesetsfrom
Conversation
mediocregopher
requested review from
Rjected,
gakonst,
joshieDo,
klkvr,
mattsse,
rakita,
rkrasiuk and
shekhirin
as code owners
RomanHodulak
approved these changes
Oct 13, 2025
shekhirin
approved these changes
Oct 13, 2025
Member
shekhirin
left a comment
shekhirin
left a comment
There was a problem hiding this comment.
LGTM, did you test with an existing config.toml to ensure that nodes won't break when upgrading to a version with these prune config changes?
Member
Author
Yup, tested locally with both empty |
mediocregopher
commented
Oct 13, 2025
Rjected
approved these changes
Oct 13, 2025
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18950
This PR contains a few related fixes:
Adds MerkleChangeSets pruning segment to the default set (it wasn't previously present)
Prune the StoragesTrieChangeSets table, not StoragesChangeSets
Allows for configuration of the MerkleChangeSets PruneMode. The PruneMode must be set for this segment, as we never want to keep the full history of trie changesets. The default is
Distance(10064). If someone really wanted to they could manually set it toBefore(0)to keep all history.Because PruneModes now has a field which can't be None it doesn't make sense to have
noneoris_emptymethods. These have been removed.