fix(rpc): fix eth_config impl#18744
Merged
mattsse merged 3 commits intoparadigmxyz:mainfrom Sep 28, 2025
Merged
Conversation
nethoxa
requested review from
Rjected,
RomanHodulak and
mattsse
as code owners
mattsse
approved these changes
Sep 27, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
lgtm, turns out we can use the existing .name function here which has the correct name already
shekhirin
pushed a commit
that referenced
this pull request
Sep 30, 2025
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
theochap
pushed a commit
to theochap/reth
that referenced
this pull request
Oct 13, 2025
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Vui-Chee
added a commit
to okx/reth
that referenced
this pull request
Nov 3, 2025
* dev: (166 commits) chore: bump 1.8.3 (paradigmxyz#19379) chore: bump alloy-evm 0.21.3 chore: bump alloy 1.0.37 (paradigmxyz#18795) chore: bump version to 1.8.2 (paradigmxyz#18792) fix(rpc/engine): check osaka in getBlobsV1 (paradigmxyz#18669) fix: remove cancun check (paradigmxyz#18787) fix(rpc): fix eth_config impl (paradigmxyz#18744) feat: make more EVM and RPC conversions fallible (paradigmxyz#18685) chore: bump rust to edition 2024 (paradigmxyz#18692) chore: release 1.8.1 (paradigmxyz#18646) fix: Revert "chore: disable fee charge in env" (paradigmxyz#18645) chore(deps): bump CodSpeedHQ/action from 3 to 4 (paradigmxyz#18333) chore: update voc.config.to text to v1.8.0 (paradigmxyz#18644) chore: update version to 1.8.0 in Cargo.toml (paradigmxyz#18638) fix: check request gas limit before (paradigmxyz#18639) chore(observability): add tokio runtime with custom thread naming (paradigmxyz#18635) docs: update dashboard table and rpc urls (paradigmxyz#18637) feat: add osaka+bpo timestamps (paradigmxyz#18627) chore: disable fee charge in env (paradigmxyz#18634) chore: bump inspectors 0.30 (paradigmxyz#18633) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two changes here:
P256precompile was wrong, it must beP256VERIFYaccording to other clients (nethermind is wrong too, writing a PR in a moment)nextisnull(and what thelastconfig means). In the EIP it is poorly explained, but in short, it is not the "previous" config, but rather the "final" config scheduled. That means, if we have configs[1, 2, 3, 4]and we are at2,last = 4andnext = 3, notlast = 1as it is the case with reth (the others do it correctly)fork_timestampsbefore checking for the current timestamp (should not be a perf drainer as the array is very small), just in case they are unordered and we claim to be on the wrong forkThe
unwrapon line 138 is safe as, by the check on line 111 we ensure there is at least one element, and with theelseon line 133 we ensure we return early if that is the case, so that we only continue execution if there are more than 1 element (so thatnext = last = current + 1if there are 2, andnext = current + 1and last is the last/final configured fork.