Skip to content

fix: check request gas limit before#18639

Merged
mattsse merged 1 commit intomainfrom
matt/check-original-request-gas
Sep 23, 2025
Merged

fix: check request gas limit before#18639
mattsse merged 1 commit intomainfrom
matt/check-original-request-gas

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 23, 2025

in #18583 we started forcing the request's gas limit, which bypassed this check entirely.

so we need to move this up

@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Sep 23, 2025
@mattsse mattsse added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation labels Sep 23, 2025
@mattsse mattsse requested a review from klkvr September 23, 2025 12:08
@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Sep 23, 2025
@mattsse mattsse enabled auto-merge September 23, 2025 12:17
@mattsse mattsse added this pull request to the merge queue Sep 23, 2025
Merged via the queue into main with commit faaebe7 Sep 23, 2025
42 checks passed
@mattsse mattsse deleted the matt/check-original-request-gas branch September 23, 2025 12:38
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Sep 23, 2025
Vui-Chee added a commit to okx/reth that referenced this pull request Nov 3, 2025
* dev: (166 commits)
  chore: bump 1.8.3 (paradigmxyz#19379)
  chore: bump alloy-evm 0.21.3
  chore: bump alloy 1.0.37 (paradigmxyz#18795)
  chore: bump version to 1.8.2 (paradigmxyz#18792)
  fix(rpc/engine): check osaka in getBlobsV1 (paradigmxyz#18669)
  fix: remove cancun check (paradigmxyz#18787)
  fix(rpc): fix eth_config impl (paradigmxyz#18744)
  feat: make more EVM and RPC conversions fallible (paradigmxyz#18685)
  chore: bump rust to edition 2024 (paradigmxyz#18692)
  chore: release 1.8.1 (paradigmxyz#18646)
  fix: Revert "chore: disable fee charge in env" (paradigmxyz#18645)
  chore(deps): bump CodSpeedHQ/action from 3 to 4 (paradigmxyz#18333)
  chore: update voc.config.to text to v1.8.0 (paradigmxyz#18644)
  chore: update version to 1.8.0 in Cargo.toml (paradigmxyz#18638)
  fix: check request gas limit before (paradigmxyz#18639)
  chore(observability): add tokio runtime with custom thread naming (paradigmxyz#18635)
  docs: update dashboard table and rpc urls (paradigmxyz#18637)
  feat: add osaka+bpo timestamps (paradigmxyz#18627)
  chore: disable fee charge in env (paradigmxyz#18634)
  chore: bump inspectors 0.30 (paradigmxyz#18633)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants