chore(observability): add tokio runtime with custom thread naming#18635
Merged
chore(observability): add tokio runtime with custom thread naming#18635
Conversation
- there's a limit in Linux kernel for thread name lengths
Member
Author
@shekhirin you were right! ran it on samply and seems like trie-tokio, wkp-tokio doesnt get created because we use the main runtime. however, think we should still keep the fallback name (trie-tokio, wkp-tokio) threads just in case it fallsbacks and we wanna know whats the run time - that would still be helpful at no cost although - the blocking one would still be relevant |
yongkangc
commented
Sep 23, 2025
Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com>
Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com>
Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com>
Member
Author
|
@shekhirin thanks for the suggestions, i think its much more intuitive now - let me know if u have any other comments! |
shekhirin
reviewed
Sep 23, 2025
shekhirin
approved these changes
Sep 23, 2025
Vui-Chee
added a commit
to okx/reth
that referenced
this pull request
Nov 3, 2025
* dev: (166 commits) chore: bump 1.8.3 (paradigmxyz#19379) chore: bump alloy-evm 0.21.3 chore: bump alloy 1.0.37 (paradigmxyz#18795) chore: bump version to 1.8.2 (paradigmxyz#18792) fix(rpc/engine): check osaka in getBlobsV1 (paradigmxyz#18669) fix: remove cancun check (paradigmxyz#18787) fix(rpc): fix eth_config impl (paradigmxyz#18744) feat: make more EVM and RPC conversions fallible (paradigmxyz#18685) chore: bump rust to edition 2024 (paradigmxyz#18692) chore: release 1.8.1 (paradigmxyz#18646) fix: Revert "chore: disable fee charge in env" (paradigmxyz#18645) chore(deps): bump CodSpeedHQ/action from 3 to 4 (paradigmxyz#18333) chore: update voc.config.to text to v1.8.0 (paradigmxyz#18644) chore: update version to 1.8.0 in Cargo.toml (paradigmxyz#18638) fix: check request gas limit before (paradigmxyz#18639) chore(observability): add tokio runtime with custom thread naming (paradigmxyz#18635) docs: update dashboard table and rpc urls (paradigmxyz#18637) feat: add osaka+bpo timestamps (paradigmxyz#18627) chore: disable fee charge in env (paradigmxyz#18634) chore: bump inspectors 0.30 (paradigmxyz#18633) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #18624 - All threads looked identical - impossible to debug or profile
Changes:
cli-tokio-{id}(e.g.,reth-cli-tokio-0,reth-cli-tokio-1)wkp-tokio-{id}(e.g.,reth-wkpool-tokio-0,reth-wkpool-tokio-1)trie-tokio-{id}(e.g.,reth-trie-tokio-0,reth-trie-tokio-1)blk-rayon-{id}(e.g.,reth-blocking-rayon-0,reth-blocking-rayon-1)reth-rayon-{id}(e.g.,reth-rayon-0,reth-rayon-1)