Skip to content

fix(rpc): less clones in logs filter#7060

Merged
mattsse merged 6 commits intomainfrom
alexey/log-matches-filter-clone
Mar 10, 2024
Merged

fix(rpc): less clones in logs filter#7060
mattsse merged 6 commits intomainfrom
alexey/log-matches-filter-clone

Conversation

@shekhirin
Copy link
Member

@shekhirin shekhirin commented Mar 8, 2024

Now possible with alloy-rs/alloy#257

@shekhirin shekhirin added C-perf A change motivated by improving speed, memory usage or disk footprint A-rpc Related to the RPC implementation labels Mar 8, 2024
@shekhirin shekhirin requested review from DaniPopes and joshieDo March 8, 2024 21:23
@shekhirin shekhirin marked this pull request as ready for review March 8, 2024 21:23
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can make this nicer in the params type and get rid of the clone

@mattsse mattsse added this pull request to the merge queue Mar 9, 2024
@mattsse mattsse removed this pull request from the merge queue due to a manual request Mar 9, 2024
@mattsse
Copy link
Collaborator

mattsse commented Mar 9, 2024

ref alloy-rs/alloy#256

@shekhirin shekhirin force-pushed the alexey/log-matches-filter-clone branch from 250fc1d to 7c1ee9a Compare March 10, 2024 13:19
mattsse added a commit to paradigmxyz/revm-inspectors that referenced this pull request Mar 10, 2024
@mattsse mattsse enabled auto-merge March 10, 2024 14:10
@mattsse mattsse added this pull request to the merge queue Mar 10, 2024
Merged via the queue into main with commit 4943619 Mar 10, 2024
@mattsse mattsse deleted the alexey/log-matches-filter-clone branch March 10, 2024 14:28
evadav-663 added a commit to evadav-663/revminc that referenced this pull request Oct 27, 2025
arublee8052-9 added a commit to arublee8052-9/revminc that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rpc Related to the RPC implementation C-perf A change motivated by improving speed, memory usage or disk footprint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants