refactor package_python_dist rule so most of the logic can be reused
#18701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognifloyd
added
needs-cherrypick
category:internal
This was referenced Apr 7, 2023
Eric-Arellano
approved these changes
Apr 7, 2023
cognifloyd
added a commit
that referenced
this pull request
Apr 8, 2023
…d (Cherry-pick of #18701) (#18703) In #18639, I have a change to allow pants to do editable installs of `python_distribution`s for in exported-mutable virtualenvs of user code. I need all of the dist chroot setup that happens in the `package_python_dist` rule, so I extracted everything that creates `DistBuildRequest` into a separate helper function.
Merged
illicitonion
added a commit
to illicitonion/pants
that referenced
this pull request
Apr 10, 2023
Internal changes: * refactor `package_python_dist` rule so most of the logic can be reused ([pantsbuild#18701](pantsbuild#18701)) * A Cloudflare Worker to handle requests to static.pantsbuild.org. ([pantsbuild#18685](pantsbuild#18685)) * No need to use lambda when setting help text for ruff ([pantsbuild#18690](pantsbuild#18690)) * Lint fixes - suggested by ruff and flake8 ([pantsbuild#18681](pantsbuild#18681)) * Skip flaky pantsd integration tests. ([pantsbuild#18665](pantsbuild#18665)) * Add types-beautifulsoup4 to default module mapping ([pantsbuild#18647](pantsbuild#18647)) * Prepare the 2.16.0rc0 release. ([pantsbuild#18645](pantsbuild#18645)) * Prepare the 2.14.2rc1 release. ([pantsbuild#18646](pantsbuild#18646)) * Prepare the 2.15.1rc1 release. ([pantsbuild#18644](pantsbuild#18644))
illicitonion
added a commit
that referenced
this pull request
Apr 10, 2023
Internal changes: * refactor `package_python_dist` rule so most of the logic can be reused ([#18701](#18701)) * A Cloudflare Worker to handle requests to static.pantsbuild.org. ([#18685](#18685)) * No need to use lambda when setting help text for ruff ([#18690](#18690)) * Lint fixes - suggested by ruff and flake8 ([#18681](#18681)) * Skip flaky pantsd integration tests. ([#18665](#18665)) * Add types-beautifulsoup4 to default module mapping ([#18647](#18647)) * Prepare the 2.16.0rc0 release. ([#18645](#18645)) * Prepare the 2.14.2rc1 release. ([#18646](#18646)) * Prepare the 2.15.1rc1 release. ([#18644](#18644))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #18639, I have a change to allow pants to do editable installs of
python_distributions for in exported-mutable virtualenvs of user code.I need all of the dist chroot setup that happens in the
package_python_distrule, so I extracted everything that createsDistBuildRequestinto a separate helper function.I would like this light refactoring to end up in 2.16.x so that I can implement #18639 as a plugin for 2.16.x, while waiting for #18639 to be merged and then released in a 2.17.x version.