Move/Rename: goals/setup_py.py
-> {util_rules,goals}/package_dists.py
+ subsystems/setup_py_generation.py
#18702
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pants v1, there was a
setup-py
goal. In pants v2, that is now part of the more genericpackage
goal. So, the namesetup_py
doesn't make sense any more.Also, most of the rules in that file are used in contexts other than the
package
goal. For instance, I'm using them in #18639 in theexport
goal. And importing something fromgoals
inutil_rules
feels rather odd. So, I would like to see most of these rules underutil_rules
.This change does the following:
pants.backends.python.goals.setup_py
topants.backends.python.util_rules.package_dists
pants.backends.python.goals.package_dists
SetupPyGeneration(Subsystem)
topants.backends.python.subsystems.setup_py_generation