A Cloudflare Worker to handle requests to static.pantsbuild.org. #18685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The worker logs the requests with both Google Analytics 4 and Universal Analytics, and then redirects to pantsbuild.github.io. The UA code is the current code we've been using for the last few years, but which we previously didn't check in to the repo. Google is phasing out UA, which is why we now add GA4 support. Once both have overlapped successfully for a while, we'll shut down the UA side. I've manually tested this code and verified that requests show up in both GA4 and UA as expected, and that the right content is returned.
benjyw
commented
Apr 5, 2023
| } | ||
|
|
||
| // UA is being phased out in mid-2023, so we'll delete this once we have GA4 set up properly. | ||
| function sendToUA(headers, host, path) { |
There was a problem hiding this comment.
The repetition, or near-repetition, is by design, so that we can easily delete this function after a suitable period of overlap.
benjyw
commented
Apr 5, 2023
| userAgent = "" // GA accepts an empty user agent, go figure. | ||
| } | ||
|
|
||
| data = { |
There was a problem hiding this comment.
The GA4 protocol is very different from the UA one, but we've been using UA for a long time, and I've verified that the GA version is correct.
|
You can add a |
|
Oh, excellent idea! |
|
Done |
stuhood
approved these changes
Apr 6, 2023
Merged
illicitonion
added a commit
to illicitonion/pants
that referenced
this pull request
Apr 10, 2023
Internal changes: * refactor `package_python_dist` rule so most of the logic can be reused ([pantsbuild#18701](pantsbuild#18701)) * A Cloudflare Worker to handle requests to static.pantsbuild.org. ([pantsbuild#18685](pantsbuild#18685)) * No need to use lambda when setting help text for ruff ([pantsbuild#18690](pantsbuild#18690)) * Lint fixes - suggested by ruff and flake8 ([pantsbuild#18681](pantsbuild#18681)) * Skip flaky pantsd integration tests. ([pantsbuild#18665](pantsbuild#18665)) * Add types-beautifulsoup4 to default module mapping ([pantsbuild#18647](pantsbuild#18647)) * Prepare the 2.16.0rc0 release. ([pantsbuild#18645](pantsbuild#18645)) * Prepare the 2.14.2rc1 release. ([pantsbuild#18646](pantsbuild#18646)) * Prepare the 2.15.1rc1 release. ([pantsbuild#18644](pantsbuild#18644))
illicitonion
added a commit
that referenced
this pull request
Apr 10, 2023
Internal changes: * refactor `package_python_dist` rule so most of the logic can be reused ([#18701](#18701)) * A Cloudflare Worker to handle requests to static.pantsbuild.org. ([#18685](#18685)) * No need to use lambda when setting help text for ruff ([#18690](#18690)) * Lint fixes - suggested by ruff and flake8 ([#18681](#18681)) * Skip flaky pantsd integration tests. ([#18665](#18665)) * Add types-beautifulsoup4 to default module mapping ([#18647](#18647)) * Prepare the 2.16.0rc0 release. ([#18645](#18645)) * Prepare the 2.14.2rc1 release. ([#18646](#18646)) * Prepare the 2.15.1rc1 release. ([#18644](#18644))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The worker logs the requests with both Google Analytics 4 and Universal Analytics, and then redirects to pantsbuild.github.io.
The UA code is the current code we've been using for the last few years, but which we previously didn't check in to the repo.
Google is phasing out UA, which is why we now add GA4 support. Once both have overlapped successfully for a while, we'll shut down the UA side.
I've manually tested this code and verified that requests show up in both GA4 and UA as expected, and that the right content is returned.