Skip to content

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Oct 4, 2025

Important changes:

  • add a new serde feature and deprecate the with-serde feature, per clippy recommendation

@nyurik nyurik requested review from tegimeki and Copilot October 4, 2025 23:50
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses minor clippy warnings and linting issues in the codebase. The changes focus on fixing spelling errors, improving documentation formatting, and refactoring feature configurations to comply with clippy recommendations.

  • Fixed spelling and formatting issues in comments and documentation
  • Refactored Cargo.toml feature configuration to address clippy::redundant_feature_names warning
  • Updated clippy lint configuration to be more selective about allowed warnings

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/parser.rs Fixed spelling error in comment and improved documentation formatting for C_identifier function
src/lib.rs Added TODO comment and clippy allow attribute for DBC struct naming
README.md Added backticks around feature names in markdown list for better formatting
Cargo.toml Refactored feature configuration and updated clippy lint settings

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codecov bot commented Oct 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@nyurik nyurik changed the title chore: more minor clippy fixes chore: new serde feature instead of deprecated with-serde Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant