Skip to content

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Oct 3, 2025

I would like to propose can-dbc switch to MIT+Apache2 license model. This is the same as most other Rust projects, makes it easier to work with bigger projects, and makes it easier to port code from https://github.com/oxibus/rrdbc

@marcelbuesing @erzoe @lucasvr @pbert519

I would like to propose `can-dbc` switch to `MIT+Apache2` license model. This is the same as most other Rust projects, makes it easier to work with bigger projects, and makes it easier to port code from https://github.com/oxibus/rrdbc
@nyurik nyurik requested a review from marcelbuesing October 3, 2025 23:18
@nyurik
Copy link
Member Author

nyurik commented Oct 4, 2025

oops, I just realized my remotes were mis-configured, and I created this PR from the primary repo - thus violating my own recommendations. My apologies, all future work will be done from my personal fork.

@nyurik
Copy link
Member Author

nyurik commented Oct 4, 2025

@marcelbuesing since you have done 99% of the work on this code - could you comment and/or merge this? I don't feel I have the right to do that :)

@Copilot Copilot AI review requested due to automatic review settings October 4, 2025 16:20
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR relicenses the can-dbc project from MIT-only to dual MIT OR Apache-2.0 licensing, following the common practice in the Rust ecosystem. This change makes the project more compatible with larger projects and facilitates code porting from related repositories.

  • Updates the Cargo.toml license field to "MIT OR Apache-2.0"
  • Adds Apache 2.0 license file (LICENSE-APACHE)
  • Updates MIT license to include OxiBUS contributors copyright

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
Cargo.toml Updates license field from "MIT" to "MIT OR Apache-2.0"
LICENSE-APACHE Adds complete Apache 2.0 license text
LICENSE-MIT Adds copyright notice for OxiBUS contributors

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codecov bot commented Oct 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@marcelbuesing
Copy link
Collaborator

@erzoe @pbert519 would be great if could also confirm that you are ok with relicensing from MIT to MIT / Apache 2.0, as you have also contributed!

@erzoe
Copy link
Contributor

erzoe commented Oct 5, 2025

I'm ok with that

@pbert519
Copy link
Contributor

pbert519 commented Oct 5, 2025 via email

@lucasvr
Copy link
Contributor

lucasvr commented Oct 5, 2025

I am fine with that, too 👍

@marcelbuesing marcelbuesing merged commit 7fc63f8 into main Oct 5, 2025
9 checks passed
@marcelbuesing marcelbuesing deleted the license branch October 5, 2025 15:57
@marcelbuesing
Copy link
Collaborator

Thank you for the quick feedback everyone :)!

@nyurik nyurik mentioned this pull request Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants