chore: move test files to submodule, default with serde feature #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the test files to a shared Git submodule and enables the with-serde feature by default to improve usability.
- Moved test files from
tests/cantools-dbcs/to the shared submoduleoxibus/shared-test-files - Enabled
with-serdefeature by default while maintaining backward compatibility
Reviewed Changes
Copilot reviewed 149 out of 149 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test-snapshots.rs | Added new test file using shared submodule for DBC parsing validation |
| tests/snapshots-dbc-cantools/*.snap | Updated snapshot files with new source paths and attribute definitions |
| tests/shared-test-files | Added Git submodule pointing to shared test files repository |
| tests/cantools-dbcs/*.dbc | Removed individual DBC test files now available in shared submodule |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Use test files from [oxibus/shared-test-files](https://github.com/oxibus/shared-test-files). This way all parsers and code generators can be tested consistently with the same set of test files.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
marcelbuesing
approved these changes
Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the test files to a shared Git submodule and enables the with-serde feature by default to improve usability.