Release/1.20.0 #1662
Merged
Release/1.20.0 #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release/1.19.0
Release/1.19.1
Release/1.19.2
… on different bg colors
Making sure the summary was displaye properly for drop down preferences
Cleaning up icons
Latest strings Removed the LEGACY disappearing messages New title for Share activity (also formatted the lines)
Missing the real string for it!
Deleting non needed files
…microphone permission
The control message is now clickable when the phone toggle is disabled or when the microphone permission is not given
…session-android into feature/strings-updates
Updated the avatar picker to match the designs. Had to rewrite it in Compose and moved the logic to the VM. We could moev the whole settings page to compose in another step now that we have the VM set up.
Group notification option was missing Using the appropriate disappearing message string Don't show 'uploading' state for quotes/replies
Feature/strings updates
Accompanist doesn't handle "ask every time" properly so we need to use our old xml methods
Reworking permission logic Added the ability to copy build number from debug menu (requested by Miki)
SES-2688 SES-2689
SES-2655 standardise thread body
SessionHero01
approved these changes
Sep 11, 2024
AL-Session
approved these changes
Sep 11, 2024
| val userPublicKey = getUserPublicKey() ?: return | ||
|
|
||
| val mmsDb = DatabaseComponent.get(context).mmsDatabase() | ||
| val message = IncomingMediaMessage( |
There was a problem hiding this comment.
I still think IncomingMediaMessage should be converted to Kotlin and we then use named parameters - because this constructor is just asking for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bringing in our changes from 1.20.0