SES-2688 SES-2689 #1660
Merged
SES-2688 SES-2689 #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reworking permission logic Added the ability to copy build number from debug menu (requested by Miki)
| @@ -143,7 +143,7 @@ public void execute() { | |||
|
|
|||
| if (!isInTargetSDKRange || permissionObject.hasAll(requestedPermissions)) { | |||
| executePreGrantedPermissionsRequest(request); | |||
| } else if (rationaleDialogMessage != null && rationalDialogHeader != null) { | |||
| } else if (rationaleDialogMessage != null) { | |||
There was a problem hiding this comment.
@SessionHero01 I modified the rationale dialog to now be able to display without a header, since we now have designs that require it. You can see in the RationaleDialog I added some code to display a generic title when no icons are provided for the header.
SessionHero01
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SES-2688
SES-2689
Reworking permission logic
Added the ability to copy build number from debug menu (requested by Miki)