[SES-2694] Incorrect back press warning message #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -78,7 +83,8 @@ internal class MessageNotificationsViewModel( | |||
|
|
|||
| data class UiState( | |||
| val pushEnabled: Boolean = true, | |||
| val showDialog: Boolean = false, | |||
| val showBackWarningDialogForNewAccount: Boolean = false, | |||
| val showBackWarningDialogForLoad: Boolean = false, | |||
There was a problem hiding this comment.
Why not integrate it in the showDialog instead? If we ever get more ways to show the message, this will become unruly.
showDialog could be a nullable string, where the dialog is hidden when the string is null and otherwise displays whatever the string is set to.
Also it seems that with this new change showBackWarningDialogForNewAccount is never set to true?
ThomasSession
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically need to tell the dialog what message to display according to state.