Skip to content

refactor(transformer/decorators): pass Class as first argument#9265

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-21-refactor_transformer_decorators_pass_class_as_first_argument
Feb 21, 2025
Merged

refactor(transformer/decorators): pass Class as first argument#9265
graphite-app[bot] merged 1 commit intomainfrom
02-21-refactor_transformer_decorators_pass_class_as_first_argument

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 21, 2025

Follow-on after #9062. Just a small code style refactor.

Make &mut Class the first param of these methods, because it's the "main" input to the function. The Address is a less important param, so can go after it.

Copy link
Member Author

overlookmotel commented Feb 21, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 21, 2025
@overlookmotel overlookmotel marked this pull request as ready for review February 21, 2025 11:19
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 21, 2025

CodSpeed Performance Report

Merging #9265 will not alter performance

Comparing 02-21-refactor_transformer_decorators_pass_class_as_first_argument (f216651) with main (bad08cf)

Summary

✅ 33 untouched benchmarks

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 21, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 21, 2025

Merge activity

Follow-on after #9062. Just a small code style refactor.

Make `&mut Class` the first param of these methods, because it's the "main" input to the function. The `Address` is a less important param, so can go after it.
@graphite-app graphite-app bot force-pushed the 02-21-refactor_transformer_decorators_get_statement_address_with_getaddress_address_ branch from ca62ce6 to f7d95cb Compare February 21, 2025 12:47
@graphite-app graphite-app bot force-pushed the 02-21-refactor_transformer_decorators_pass_class_as_first_argument branch from 555cdf3 to f216651 Compare February 21, 2025 12:48
Base automatically changed from 02-21-refactor_transformer_decorators_get_statement_address_with_getaddress_address_ to main February 21, 2025 12:51
@graphite-app graphite-app bot merged commit f216651 into main Feb 21, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 02-21-refactor_transformer_decorators_pass_class_as_first_argument branch February 21, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant