refactor(transformer): do not use &mut when & ref will do#9266
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 21, 2025
Merged
Conversation
This was referenced Feb 21, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-transformer
Member
Author
|
@Dunqing Just to flag that this PR touches many files in the transformer. Please can you merge this before any other transformer PRs, to avoid merge conflicts? |
CodSpeed Performance ReportMerging #9266 will not alter performanceComparing Summary
|
Member
Merge activity
|
#9253 enabled clippy's `needless_pass_by_ref_mut` rule, but kept it disabled for the `oxc_transformer` crate. This rule is really good as using `&` instead of `&mut` may allow the compiler to make more optimizations in some cases, as `&` guarantees that value is not changed during the function call which takes `&`. Enable this lint and fix all the warnings it highlights. The diff is large, but it's purely replacing `&mut` with `&` in lots of places.
graphite-app
bot
force-pushed
the
02-21-refactor_transformer_decorators_pass_class_as_first_argument
branch
from
555cdf3 to
f216651
Compare
graphite-app
bot
force-pushed
the
02-21-refactor_transformer_do_not_use_mut_when_ref_will_do
branch
from
1fd6df9 to
2501c63
Compare
Base automatically changed from
02-21-refactor_transformer_decorators_pass_class_as_first_argument
to
main
February 21, 2025 12:55
graphite-app
bot
deleted the
02-21-refactor_transformer_do_not_use_mut_when_ref_will_do
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9253 enabled clippy's
needless_pass_by_ref_mutrule, but kept it disabled for theoxc_transformercrate.This rule is really good as using
&instead of&mutmay allow the compiler to make more optimizations in some cases, as&guarantees that value is not changed during the function call which takes&.Enable this lint and fix all the warnings it highlights.
The diff is large, but it's purely replacing
&mutwith&in lots of places.