Skip to content

refactor(transformer/decorators): pass Class as first argument #9265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Feb 21, 2025
Merged

refactor(transformer/decorators): pass Class as first argument #9265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions crates/oxc_transformer/src/decorator/legacy/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,8 @@ impl<'a> LegacyDecorator<'a, '_> {
fn transform_class(&mut self, stmt: &mut Statement<'a>, ctx: &mut TraverseCtx<'a>) {
let Statement::ClassDeclaration(class) = stmt else { unreachable!() };

if let Some((_, new_stmt)) = self.transform_class_impl(class.address(), class, ctx) {
let stmt_address = class.address();
if let Some((_, new_stmt)) = self.transform_class_impl(class, stmt_address, ctx) {
*stmt = new_stmt;
}
}
Expand Down Expand Up @@ -210,7 +211,7 @@ impl<'a> LegacyDecorator<'a, '_> {
return;
};

let Some((class_binding, new_stmt)) = self.transform_class_impl(stmt_address, class, ctx)
let Some((class_binding, new_stmt)) = self.transform_class_impl(class, stmt_address, ctx)
else {
return;
};
Expand Down Expand Up @@ -259,7 +260,7 @@ impl<'a> LegacyDecorator<'a, '_> {
let stmt_address = export.address();
let Some(Declaration::ClassDeclaration(class)) = &mut export.declaration else { return };

let Some((class_binding, new_stmt)) = self.transform_class_impl(stmt_address, class, ctx)
let Some((class_binding, new_stmt)) = self.transform_class_impl(class, stmt_address, ctx)
else {
return;
};
Expand All @@ -272,8 +273,8 @@ impl<'a> LegacyDecorator<'a, '_> {

fn transform_class_impl(
&mut self,
stmt_address: Address,
class: &mut Class<'a>,
stmt_address: Address,
ctx: &mut TraverseCtx<'a>,
) -> Option<(BoundIdentifier<'a>, Statement<'a>)> {
let ClassDecoratorInfo {
Expand All @@ -290,8 +291,8 @@ impl<'a> LegacyDecorator<'a, '_> {
));
} else if class_element_is_decorated {
self.transform_class_declaration_without_class_decorators(
stmt_address,
class,
stmt_address,
has_private_in_expression_in_decorator,
ctx,
);
Expand Down Expand Up @@ -462,8 +463,8 @@ impl<'a> LegacyDecorator<'a, '_> {
/// Transforms a non-decorated class declaration.
fn transform_class_declaration_without_class_decorators(
&mut self,
stmt_address: Address,
class: &mut Class<'a>,
stmt_address: Address,
has_private_in_expression_in_decorator: bool,
ctx: &mut TraverseCtx<'a>,
) {
Expand Down
Loading