Skip to content

fix(ast/estree): fix serializing BigInts#9022

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-10-fix_ast_estree_fix_serializing_bigint_s
Feb 10, 2025
Merged

fix(ast/estree): fix serializing BigInts#9022
graphite-app[bot] merged 1 commit intomainfrom
02-10-fix_ast_estree_fix_serializing_bigint_s

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 10, 2025

Fix serialization of BigIntLiterals. Turns out ESTree takes a much simpler approach than we were taking!

Copy link
Member Author

overlookmotel commented Feb 10, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel force-pushed the 02-10-fix_ast_estree_fix_serializing_bigint_s branch from 48f8cb0 to b0733db Compare February 10, 2025 17:06
@github-actions github-actions bot added A-ast Area - AST C-bug Category - Bug labels Feb 10, 2025
@overlookmotel overlookmotel marked this pull request as ready for review February 10, 2025 17:08
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 10, 2025

CodSpeed Performance Report

Merging #9022 will not alter performance

Comparing 02-10-fix_ast_estree_fix_serializing_bigint_s (cac5545) with main (9427007)

Summary

✅ 33 untouched benchmarks

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Feb 10, 2025
Copy link
Member Author

overlookmotel commented Feb 10, 2025

Merge activity

  • Feb 10, 12:49 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 10, 12:49 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 10, 12:57 PM EST: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Feb 10, 12:59 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 10, 1:03 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 10, 1:08 PM EST: A user merged this pull request with the Graphite merge queue.

@overlookmotel overlookmotel changed the base branch from 02-10-fix_ast_estree_use_estree_append_to_for_tsmoduleblock_ to graphite-base/9022 February 10, 2025 17:49
@graphite-app graphite-app bot changed the base branch from graphite-base/9022 to main February 10, 2025 17:55
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 10, 2025
@overlookmotel overlookmotel force-pushed the 02-10-fix_ast_estree_fix_serializing_bigint_s branch from b0733db to dd9fdd5 Compare February 10, 2025 17:58
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Feb 10, 2025
Fix serialization of `BigIntLiteral`s. Turns out ESTree takes a much simpler approach than we were taking!
@graphite-app graphite-app bot force-pushed the 02-10-fix_ast_estree_fix_serializing_bigint_s branch from dd9fdd5 to cac5545 Compare February 10, 2025 18:03
@graphite-app graphite-app bot merged commit cac5545 into main Feb 10, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 02-10-fix_ast_estree_fix_serializing_bigint_s branch February 10, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant