Skip to content

refactor(ast/estree): re-arrange and comment custom serialization code#9019

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-10-refactor_ast_estree_re-arrange_and_comment_custom_serialization_code
Feb 10, 2025
Merged

refactor(ast/estree): re-arrange and comment custom serialization code#9019
graphite-app[bot] merged 1 commit intomainfrom
02-10-refactor_ast_estree_re-arrange_and_comment_custom_serialization_code

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 10, 2025

Pure refactor. Organise serialization code into sections and comment what it does. No changes to code itself.

Copy link
Member Author

overlookmotel commented Feb 10, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 10, 2025
@overlookmotel overlookmotel marked this pull request as ready for review February 10, 2025 16:20
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 10, 2025

CodSpeed Performance Report

Merging #9019 will not alter performance

Comparing 02-10-refactor_ast_estree_re-arrange_and_comment_custom_serialization_code (eef8874) with main (8db4727)

Summary

✅ 33 untouched benchmarks

@overlookmotel overlookmotel changed the base branch from 02-10-refactor_ast_estree_remove_serialization_wrapper to graphite-base/9019 February 10, 2025 16:36
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Feb 10, 2025
Copy link
Member Author

overlookmotel commented Feb 10, 2025

Merge activity

  • Feb 10, 11:37 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 10, 11:37 AM EST: A user added this pull request to the Graphite merge queue.
  • Feb 10, 11:43 AM EST: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Feb 10, 12:48 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 10, 12:48 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 10, 12:53 PM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot changed the base branch from graphite-base/9019 to main February 10, 2025 16:42
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 10, 2025
@overlookmotel overlookmotel force-pushed the 02-10-refactor_ast_estree_re-arrange_and_comment_custom_serialization_code branch from 3cd4374 to dd717d8 Compare February 10, 2025 17:04
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Feb 10, 2025
#9019)

Pure refactor. Organise serialization code into sections and comment what it does. No changes to code itself.
@graphite-app graphite-app bot force-pushed the 02-10-refactor_ast_estree_re-arrange_and_comment_custom_serialization_code branch from dd717d8 to eef8874 Compare February 10, 2025 17:49
@graphite-app graphite-app bot merged commit eef8874 into main Feb 10, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 02-10-refactor_ast_estree_re-arrange_and_comment_custom_serialization_code branch February 10, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant