fix(ast/estree): use #[estree(append_to)] for TSModuleBlock#9020
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 10, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #9020 will not alter performanceComparing Summary
|
Member
Author
Merge activity
|
overlookmotel
force-pushed
the
02-10-fix_ast_estree_use_estree_append_to_for_tsmoduleblock_
branch
from
f31ab46 to
f6fef1b
Compare
overlookmotel
force-pushed
the
02-10-refactor_ast_estree_re-arrange_and_comment_custom_serialization_code
branch
from
3cd4374 to
dd717d8
Compare
Replace custom `Serialize` impl for `TSModuleBlock` by using `#[estree(append_to)]` instead. This also fixes the TS type def for `TSModuleBlock`.
graphite-app
bot
force-pushed
the
02-10-refactor_ast_estree_re-arrange_and_comment_custom_serialization_code
branch
from
dd717d8 to
eef8874
Compare
graphite-app
bot
force-pushed
the
02-10-fix_ast_estree_use_estree_append_to_for_tsmoduleblock_
branch
from
f6fef1b to
9427007
Compare
Base automatically changed from
02-10-refactor_ast_estree_re-arrange_and_comment_custom_serialization_code
to
main
February 10, 2025 17:53
graphite-app
bot
deleted the
02-10-fix_ast_estree_use_estree_append_to_for_tsmoduleblock_
branch
This was referenced Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace custom
Serializeimpl forTSModuleBlockby using#[estree(append_to)]instead. This also fixes the TS type def forTSModuleBlock.