feat(minifier): fold simple literals passed to unary +#8943
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 7, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Feb 7, 2025
github-actions
bot
added
A-minifier
CodSpeed Performance ReportMerging #8943 will not alter performanceComparing Summary
|
sapphi-red
commented
Feb 7, 2025
This was referenced Feb 7, 2025
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
02-06-fix_minifier_fix_comparison_of_strings_with_unicode_characters
branch
from
8b64a88 to
b5a7785
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
Added support for folding `+[]` and `+/any-regex/`. `+` uses `ToNumber` and `ToNumber` uses `ToPrimitive` for objects. `ToPrimitive` for `[]` returns `""`, for `/any-regex/` it returns `"/any-regex/"`. **References** - [Spec of unary `+`](https://tc39.es/ecma262/multipage/ecmascript-language-expressions.html#sec-unary-plus-operator-runtime-semantics-evaluation) - [Spec of `ToPrimitive`](https://tc39.es/ecma262/multipage/abstract-operations.html#sec-toprimitive)
graphite-app
bot
force-pushed
the
02-06-feat_minifier_fold_simple_literals_passed_to_unary_
branch
from
2b20341 to
6357a2b
Compare
Base automatically changed from
02-06-fix_minifier_fix_comparison_of_strings_with_unicode_characters
to
main
February 7, 2025 13:54
sapphi-red
force-pushed
the
02-06-feat_minifier_fold_simple_literals_passed_to_unary_
branch
from
6357a2b to
7ec8a28
Compare
Added support for folding `+[]` and `+/any-regex/`. `+` uses `ToNumber` and `ToNumber` uses `ToPrimitive` for objects. `ToPrimitive` for `[]` returns `""`, for `/any-regex/` it returns `"/any-regex/"`. **References** - [Spec of unary `+`](https://tc39.es/ecma262/multipage/ecmascript-language-expressions.html#sec-unary-plus-operator-runtime-semantics-evaluation) - [Spec of `ToPrimitive`](https://tc39.es/ecma262/multipage/abstract-operations.html#sec-toprimitive)
graphite-app
bot
force-pushed
the
02-06-feat_minifier_fold_simple_literals_passed_to_unary_
branch
from
7ec8a28 to
14462be
Compare
graphite-app
bot
deleted the
02-06-feat_minifier_fold_simple_literals_passed_to_unary_
branch
Dunqing
pushed a commit
that referenced
this pull request
Feb 10, 2025
Added support for folding `+[]` and `+/any-regex/`. `+` uses `ToNumber` and `ToNumber` uses `ToPrimitive` for objects. `ToPrimitive` for `[]` returns `""`, for `/any-regex/` it returns `"/any-regex/"`. **References** - [Spec of unary `+`](https://tc39.es/ecma262/multipage/ecmascript-language-expressions.html#sec-unary-plus-operator-runtime-semantics-evaluation) - [Spec of `ToPrimitive`](https://tc39.es/ecma262/multipage/abstract-operations.html#sec-toprimitive)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for folding
+[]and+/any-regex/.+usesToNumberandToNumberusesToPrimitivefor objects.ToPrimitivefor[]returns"", for/any-regex/it returns"/any-regex/".References
+ToPrimitive