fix(minifier): fix comparison of strings with unicode characters

[sapphi-red]

In IsLessThan, strings are compared by the following step.

3. If px is a String and py is a String, then
   a. Let lx be the length of px.
   b. Let ly be the length of py.
   c. For each integer i such that 0 ≤ i < min(lx, ly), in ascending order, do
   i. Let cx be the numeric value of the code unit at index i within px.
   ii. Let cy be the numeric value of the code unit at index i within py.
   iii. If cx < cy, return true.
   iv. If cx > cy, return false.
   d. If lx < ly, return true. Otherwise, return false.

Quoting the note below the algorithm

The comparison of Strings uses a simple lexicographic ordering on sequences of UTF-16 code unit values.

It compares the UTF-16 code unit. The previous code was using UTF-8 code unit.

References

• Spec of IsLessThan

[sapphi-red]

• feat(minifier): fold typeof class {} to 'function' #8949
• feat(minifier): fold typeof (() => {}) to 'function' #8948
• feat(minifier): fold typeof { foo } when foo is declared #8947
• feat(minifier): fold complicated array literals passed to unary + #8944
• feat(minifier): fold simple literals passed to unary + #8943
• fix(minifier): fix comparison of strings with unicode characters #8942 👈 (View in Graphite)
• test(minifier): enable esbuild constant evaluation tests #8941
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #8942 will not alter performance

_{Comparing 02-06-fix_minifier_fix_comparison_of_strings_with_unicode_characters (b5a7785) with main (41ad42a)}

Summary

✅ 33 untouched benchmarks

[graphite-app]

Merge activity

• Feb 7, 8:30 AM EST: A user added this pull request to the Graphite merge queue.
• Feb 7, 8:54 AM EST: A user merged this pull request with the Graphite merge queue.