Skip to content

feat(minifier): fold simple literals passed to unary + #8943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Feb 7, 2025
Merged

feat(minifier): fold simple literals passed to unary + #8943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions crates/oxc_ecmascript/src/constant_evaluation/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,20 @@ pub trait ConstantEvaluation<'a>: MayHaveSideEffects {
Expression::SequenceExpression(s) => {
s.expressions.last().and_then(|e| self.eval_to_number(e))
}
// If the object is empty, `toString` / `valueOf` / `Symbol.toPrimitive` is not overridden.
// (assuming that those methods in Object.prototype are not modified)
// In that case, `ToPrimitive` returns `"[object Object]"`
Expression::ObjectExpression(e) if e.properties.is_empty() => Some(f64::NAN),
// `ToPrimitive` for RegExp object returns `"/regexp/"`
Expression::RegExpLiteral(_) => Some(f64::NAN),
Expression::ArrayExpression(arr) => {
// If the array is empty, `ToPrimitive` returns `""`
if arr.elements.is_empty() {
Some(0.0)
} else {
None
}
}
expr => {
use crate::ToNumber;
expr.to_number()
Expand Down
4 changes: 2 additions & 2 deletions crates/oxc_minifier/tests/peephole/esbuild.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -891,9 +891,9 @@ fn constant_evaluation_test() {
test("x = !5", "x = !1;");
test("x = typeof 5", "x = 'number';");
test("x = +''", "x = 0;");
// test("x = +[]", "x = 0;");
test("x = +[]", "x = 0;");
test("x = +{}", "x = NaN;");
// test("x = +/1/", "x = NaN;");
test("x = +/1/", "x = NaN;");
test("x = +[1]", "x = +[1];");
test("x = +'123'", "x = 123;");
test("x = +'-123'", "x = -123;");
Expand Down
Loading