Skip to content

refactor(traverse)!: remove TraverseCtx::is_static#7760

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-09-refactor_traverse_remove_traversectx_is_static_
Dec 10, 2024
Merged

refactor(traverse)!: remove TraverseCtx::is_static#7760
graphite-app[bot] merged 1 commit intomainfrom
12-09-refactor_traverse_remove_traversectx_is_static_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Dec 9, 2024

TraverseCtx::is_static was only used in logical assignment operators transform, and #7745 removed that usage. So remove this method. TransformCtx::duplicate_expression fulfills the same role.

@github-actions github-actions bot added C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior A-transformer Area - Transformer / Transpiler labels Dec 9, 2024
@overlookmotel overlookmotel force-pushed the 12-09-feat_transformer_logical-assignment-operators_no_temp_vars_for_literals branch from 22c18fe to 44c3254 Compare December 9, 2024 21:54
@overlookmotel overlookmotel force-pushed the 12-09-refactor_traverse_remove_traversectx_is_static_ branch from e5517f4 to 1d1c902 Compare December 9, 2024 21:55
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 9, 2024

CodSpeed Performance Report

Merging #7760 will create unknown performance changes

Comparing 12-09-refactor_traverse_remove_traversectx_is_static_ (5d6fa25) with 12-09-feat_transformer_logical-assignment-operators_no_temp_vars_for_literals (e010b6a)

Summary

🆕 29 new benchmarks

Benchmarks breakdown

Benchmark 12-09-feat_transformer_logical-assignment-operators_no_temp_vars_for_literals 12-09-refactor_traverse_remove_traversectx_is_static_ Change
🆕 codegen[checker.ts] N/A 25.3 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 76.9 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 725.6 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 24.1 µs N/A
🆕 lexer[antd.js] N/A 22.3 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.5 ms N/A
🆕 lexer[checker.ts] N/A 13.2 ms N/A
🆕 lexer[pdf.mjs] N/A 3.6 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.5 ms N/A
🆕 linter[cal.com.tsx] N/A 1.1 s N/A
🆕 linter[checker.ts] N/A 2.7 s N/A
🆕 minifier[antd.js] N/A 221.6 ms N/A
🆕 minifier[react.development.js] N/A 2.1 ms N/A
🆕 minifier[typescript.js] N/A 381.6 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 87.9 µs N/A
🆕 parser[antd.js] N/A 107.2 ms N/A
🆕 parser[cal.com.tsx] N/A 29.6 ms N/A
🆕 parser[checker.ts] N/A 53.9 ms N/A
🆕 parser[pdf.mjs] N/A 17.5 ms N/A
🆕 semantic[RadixUIAdoptionSection.jsx] N/A 75 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@overlookmotel overlookmotel marked this pull request as ready for review December 9, 2024 22:17
@overlookmotel overlookmotel force-pushed the 12-09-feat_transformer_logical-assignment-operators_no_temp_vars_for_literals branch from 44c3254 to 71ed650 Compare December 9, 2024 22:34
@overlookmotel overlookmotel force-pushed the 12-09-refactor_traverse_remove_traversectx_is_static_ branch from 1d1c902 to 2bcaebc Compare December 9, 2024 22:34
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 10, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 10, 2024

Merge activity

`TraverseCtx::is_static` was only used in logical assignment operators transform, and #7745 removed that usage. So remove this method. `TransformCtx::duplicate_expression` fulfills the same role.
@Dunqing Dunqing force-pushed the 12-09-feat_transformer_logical-assignment-operators_no_temp_vars_for_literals branch from 71ed650 to e010b6a Compare December 10, 2024 02:32
@Dunqing Dunqing requested a review from Boshen as a code owner December 10, 2024 02:32
@Dunqing Dunqing force-pushed the 12-09-refactor_traverse_remove_traversectx_is_static_ branch from 2bcaebc to 5d6fa25 Compare December 10, 2024 02:32
Base automatically changed from 12-09-feat_transformer_logical-assignment-operators_no_temp_vars_for_literals to main December 10, 2024 03:06
@graphite-app graphite-app bot merged commit 5d6fa25 into main Dec 10, 2024
@graphite-app graphite-app bot deleted the 12-09-refactor_traverse_remove_traversectx_is_static_ branch December 10, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant