refactor(traverse)!: remove TraverseCtx::is_static#7760
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 10, 2024
Merged
refactor(traverse)!: remove TraverseCtx::is_static#7760graphite-app[bot] merged 1 commit intomainfrom
TraverseCtx::is_static#7760graphite-app[bot] merged 1 commit intomainfrom
Conversation
This was referenced Dec 9, 2024
Member
Author
22c18fe to
44c3254
Compare
e5517f4 to
1d1c902
Compare
CodSpeed Performance ReportMerging #7760 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
44c3254 to
71ed650
Compare
1d1c902 to
2bcaebc
Compare
Contributor
Merge activity
|
`TraverseCtx::is_static` was only used in logical assignment operators transform, and #7745 removed that usage. So remove this method. `TransformCtx::duplicate_expression` fulfills the same role.
71ed650 to
e010b6a
Compare
2bcaebc to
5d6fa25
Compare
Base automatically changed from
12-09-feat_transformer_logical-assignment-operators_no_temp_vars_for_literals
to
main
December 10, 2024 03:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TraverseCtx::is_staticwas only used in logical assignment operators transform, and #7745 removed that usage. So remove this method.TransformCtx::duplicate_expressionfulfills the same role.