Skip to content

refactor(transformer): duplicate_expression do not produce temp var for super#7757

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-09-refactor_transformer_duplicate_expression_do_not_produce_temp_var_for_super_
Dec 10, 2024
Merged

refactor(transformer): duplicate_expression do not produce temp var for super#7757
graphite-app[bot] merged 1 commit intomainfrom
12-09-refactor_transformer_duplicate_expression_do_not_produce_temp_var_for_super_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Dec 9, 2024

TransformCtx::duplicate_expression method introduced in #7754 don't create a temp var for super. This prepares it for use in logical assignment operator transform (#7745).

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 9, 2024

CodSpeed Performance Report

Merging #7757 will not alter performance

Comparing 12-09-refactor_transformer_duplicate_expression_do_not_produce_temp_var_for_super_ (9c2a1b6) with main (3c1b2bf)

Summary

✅ 29 untouched benchmarks

@overlookmotel overlookmotel marked this pull request as ready for review December 9, 2024 22:08
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 10, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 10, 2024

Merge activity

… for `super` (#7757)

`TransformCtx::duplicate_expression` method introduced in #7754 don't create a temp var for `super`. This prepares it for use in logical assignment operator transform (#7745).
@Dunqing Dunqing force-pushed the 12-09-refactor_transformer_duplicate_expression_take_mutated_symbol_needs_temp_var_param branch from 04f6445 to a750ebc Compare December 10, 2024 02:29
@Dunqing Dunqing requested a review from Boshen as a code owner December 10, 2024 02:29
@Dunqing Dunqing force-pushed the 12-09-refactor_transformer_duplicate_expression_do_not_produce_temp_var_for_super_ branch from 5e49bbd to 9c2a1b6 Compare December 10, 2024 02:30
Base automatically changed from 12-09-refactor_transformer_duplicate_expression_take_mutated_symbol_needs_temp_var_param to main December 10, 2024 02:50
@graphite-app graphite-app bot merged commit 9c2a1b6 into main Dec 10, 2024
@graphite-app graphite-app bot deleted the 12-09-refactor_transformer_duplicate_expression_do_not_produce_temp_var_for_super_ branch December 10, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant