fix(transformer/logic-assignment-operator): always create IdentifierReferences with ReferenceId

[overlookmotel]

Use TransformCtx::duplicate_expression (introduced in #7754) to decide when to create temp vars for member expression object and computed property.

This fixes a bug where IdentifierReferences created when transforming key in object[key] &&= value were created without a ReferenceId (due to clone_in).

We didn't catch this before because Babel's test fixtures only cover object[key++] &&= value not the simpler object[key] &&= value. Add tests for this.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[overlookmotel]

• feat(transformer/class-properties): support private_fields_as_properties assumption #7717
• refactor(traverse)!: remove TraverseCtx::is_static #7760
• feat(transformer/logical-assignment-operators): no temp vars for literals #7759
• test(transformer): enable fixture overrides for logical-assignment-operators transform #7758
• fix(transformer/logic-assignment-operator): always create IdentifierReferences with ReferenceId #7745 👈 (View in Graphite)
• refactor(transformer): duplicate_expression do not produce temp var for super #7757
• refactor(transformer): duplicate_expression take mutated_symbol_needs_temp_var param #7756
• feat(semantic): add SymbolTable::symbol_is_mutated method #7755
• refactor(transformer): introduce TransformCtx::duplicate_expression #7754
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[overlookmotel]

I'm seeing weird interactions between logical assignment operator + class properties transforms. I thought the fault might be in logical assignment operator transform, so that's why I added these tests. But no! They pass. 😢

[overlookmotel]

Ah ha no! I made a mistake in the tests. The problem is in this transform. I'll try to fix.

[codspeed-hq]

CodSpeed Performance Report

Merging #7745 will not alter performance

_{Comparing 12-09-test_transformer_logic-assignment-operator_add_more_tests (e48769a) with 12-09-refactor_transformer_duplicate_expression_do_not_produce_temp_var_for_super_ (5e49bbd)}

Summary

✅ 29 untouched benchmarks

[overlookmotel]

@Dunqing Could you please take a look and make sure I'm not missing anything? I think this simplification of the code retains its original behavior, but I don't know this transform, so I might have made a mistake.

[overlookmotel]

There is one thing I changed. Previously some MemberExpressions were created with optional: computed_expr.optional. But I've just got optional: false.

I think this is OK, because object?.prop &&= value and object?.[prop] &&= value are invalid syntax, so optional should always be false anyway. I think...

[graphite-app]

Merge activity

• Dec 9, 9:27 PM EST: A user added this pull request to the Graphite merge queue.
• Dec 9, 9:58 PM EST: A user merged this pull request with the Graphite merge queue.