Skip to content

perf(transformer/arrow-functions): inline hot visitors #7329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
overlookmotel wants to merge 1 commit into from
Closed

perf(transformer/arrow-functions): inline hot visitors #7329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions crates/oxc_transformer/src/common/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,8 @@ impl<'a, 'ctx> Traverse<'a> for Common<'a, 'ctx> {
self.arrow_function_converter.exit_expression(expr, ctx);
}

// `#[inline]` because this is a hot path and `arrow_function_converter`'s function is small
#[inline]
fn enter_binding_identifier(
&mut self,
node: &mut BindingIdentifier<'a>,
Expand All @@ -128,6 +130,8 @@ impl<'a, 'ctx> Traverse<'a> for Common<'a, 'ctx> {
self.arrow_function_converter.enter_binding_identifier(node, ctx);
}

// `#[inline]` because this is a hot path and `arrow_function_converter`'s function is small
#[inline]
fn enter_identifier_reference(
&mut self,
node: &mut IdentifierReference<'a>,
Expand Down
4 changes: 4 additions & 0 deletions crates/oxc_transformer/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,8 @@ impl<'a, 'ctx> Traverse<'a> for TransformerImpl<'a, 'ctx> {
self.x2_es2020.enter_big_int_literal(node, ctx);
}

// `#[inline]` because this is a hot path and function at end of chain in `common` transform is small
#[inline]
fn enter_binding_identifier(
&mut self,
node: &mut BindingIdentifier<'a>,
Expand All @@ -199,6 +201,8 @@ impl<'a, 'ctx> Traverse<'a> for TransformerImpl<'a, 'ctx> {
self.common.enter_binding_identifier(node, ctx);
}

// `#[inline]` because this is a hot path and function at end of chain in `common` transform is small
#[inline]
fn enter_identifier_reference(
&mut self,
node: &mut IdentifierReference<'a>,
Expand Down