refactor(ast, transformer)!: remove BlockStatement::new methods

[overlookmotel]

First of a series of PRs removing new and new_with_scope_id etc methods from AST types. Following #6760, all AST node creation can now go via the AST builder.

This lays groundwork for Node IDs (#5689), as we'll need NodeIds to be generated in AstBuilder, so that all nodes receive an ID.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[overlookmotel]

• refactor(ast)!: remove unused new methods #6789
• refactor(ast, transformer)!: remove StringLiteral::new method #6788
• refactor(ast, parser)!: remove NumericLiteral::new method #6787
• refactor(ast, parser, transformer, traverse)!: remove BindingIdentifier::new methods #6786
• refactor(ast, parser, transformer, traverse)!: remove IdentifierReference::new methods #6785
• refactor(ast, transformer)!: remove IdentifierName::new method #6784
• refactor(ast, transformer)!: remove BlockStatement::new methods #6783 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite

[overlookmotel]

@Boshen I imagine something in this stack will break Rolldown. I assume they have access to AstBuilder, so it'll be an easy fix to migrate over to using AstBuilder methods to generate AST nodes?

[codspeed-hq]

CodSpeed Performance Report

Merging #6783 will not alter performance

_{Comparing 10-22-refactor_ast_transformer_remove_blockstatement_new_methods (2bee4e2) with main (8f17953)}

Summary

✅ 30 untouched benchmarks

[graphite-app]

Merge activity

• Oct 22, 11:35 PM EDT: A user added this pull request to the Graphite merge queue.
• Oct 22, 11:41 PM EDT: A user merged this pull request with the Graphite merge queue.