Skip to content

Comments

refactor(ast)!: remove unused new methods#6789

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-22-refactor_ast_remove_unused_new_methods
Oct 23, 2024
Merged

refactor(ast)!: remove unused new methods#6789
graphite-app[bot] merged 1 commit intomainfrom
10-22-refactor_ast_remove_unused_new_methods

Conversation

@overlookmotel
Copy link
Member

No description provided.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@overlookmotel overlookmotel changed the title refactor(ast): remove unused new methods refactor(ast)!: remove unused new methods Oct 22, 2024
@overlookmotel overlookmotel marked this pull request as ready for review October 22, 2024 17:07
@github-actions github-actions bot added A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 22, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 22, 2024

CodSpeed Performance Report

Merging #6789 will not alter performance

Comparing 10-22-refactor_ast_remove_unused_new_methods (718ccde) with 10-22-refactor_ast_transformer_remove_stringliteral_new_method (4d2d214)

Summary

✅ 30 untouched benchmarks

@DonIsaac
Copy link
Contributor

I love API reductions. LGTM.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 23, 2024
Copy link
Member

Boshen commented Oct 23, 2024

Merge activity

  • Oct 22, 11:35 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 22, 11:36 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 23, 12:07 AM EDT: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 10-22-refactor_ast_transformer_remove_stringliteral_new_method branch from 60b0975 to 4d2d214 Compare October 23, 2024 03:39
@Boshen Boshen force-pushed the 10-22-refactor_ast_remove_unused_new_methods branch from dd3781e to 718ccde Compare October 23, 2024 03:39
Base automatically changed from 10-22-refactor_ast_transformer_remove_stringliteral_new_method to main October 23, 2024 04:04
@graphite-app graphite-app bot merged commit 718ccde into main Oct 23, 2024
@graphite-app graphite-app bot deleted the 10-22-refactor_ast_remove_unused_new_methods branch October 23, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants