Skip to content

Comments

docs(ast): enable crate-wide warnings on missing doc comments#6716

Merged
graphite-app[bot] merged 1 commit intomainfrom
don/10-20-docs_ast_enable_crate-wide_warnins_on_missing_doc_comments
Oct 24, 2024
Merged

docs(ast): enable crate-wide warnings on missing doc comments#6716
graphite-app[bot] merged 1 commit intomainfrom
don/10-20-docs_ast_enable_crate-wide_warnins_on_missing_doc_comments

Conversation

@DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Oct 20, 2024

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 20, 2024

CodSpeed Performance Report

Merging #6716 will not alter performance

Comparing don/10-20-docs_ast_enable_crate-wide_warnins_on_missing_doc_comments (63ce9be) with main (ca79993)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 21, 2024
@Boshen Boshen changed the title docs(ast): enable crate-wide warnins on missing doc comments docs(ast): enable crate-wide warnings on missing doc comments Oct 21, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 21, 2024

Merge activity

  • Oct 20, 10:20 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 20, 10:36 PM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #6713.
  • Oct 20, 10:37 PM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #6713.
  • Oct 21, 1:24 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 21, 1:30 AM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Oct 21, 1:33 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 21, 1:35 AM EDT: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Oct 23, 9:36 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 23, 9:40 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 23, 9:44 PM EDT: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 21, 2024
@DonIsaac DonIsaac force-pushed the don/10-20-docs_ast_enforce_doc_comments_on_ast_node_methods branch from 2e2fa03 to 8e98780 Compare October 21, 2024 05:23
@DonIsaac DonIsaac force-pushed the don/10-20-docs_ast_enable_crate-wide_warnins_on_missing_doc_comments branch from 5f04c35 to 126ea42 Compare October 21, 2024 05:23
@DonIsaac DonIsaac added the 0-merge Merge with Graphite Merge Queue label Oct 21, 2024
@DonIsaac DonIsaac force-pushed the don/10-20-docs_ast_enforce_doc_comments_on_ast_node_methods branch from 8e98780 to a7dd5aa Compare October 21, 2024 05:29
@DonIsaac DonIsaac changed the base branch from don/10-20-docs_ast_enforce_doc_comments_on_ast_node_methods to main October 21, 2024 05:30
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 21, 2024
@Boshen Boshen self-assigned this Oct 22, 2024
@Boshen Boshen force-pushed the don/10-20-docs_ast_enable_crate-wide_warnins_on_missing_doc_comments branch from 126ea42 to 35c54d8 Compare October 24, 2024 01:36
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 24, 2024
@Boshen Boshen force-pushed the don/10-20-docs_ast_enable_crate-wide_warnins_on_missing_doc_comments branch from 35c54d8 to 63ce9be Compare October 24, 2024 01:40
@graphite-app graphite-app bot merged commit 63ce9be into main Oct 24, 2024
@graphite-app graphite-app bot deleted the don/10-20-docs_ast_enable_crate-wide_warnins_on_missing_doc_comments branch October 24, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST A-ast-tools Area - AST tools C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants