Skip to content

docs(codegen): add #![warn(missing_docs)] to oxc_codegen#6711

Merged
graphite-app[bot] merged 1 commit intomainfrom
don/10-20-docs_codegen_add_warn_missing_docs_to_oxc_codegen_
Oct 21, 2024
Merged

docs(codegen): add #![warn(missing_docs)] to oxc_codegen#6711
graphite-app[bot] merged 1 commit intomainfrom
don/10-20-docs_codegen_add_warn_missing_docs_to_oxc_codegen_

Conversation

@DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Oct 20, 2024

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-codegen Area - Code Generation C-docs Category - Documentation. Related to user-facing or internal documentation labels Oct 20, 2024
@DonIsaac DonIsaac marked this pull request as ready for review October 20, 2024 19:36
@DonIsaac DonIsaac force-pushed the don/10-20-doc_macros_add_warn_missing_docs_to_oxc_macros_ branch from 5644bf4 to 5eedc3d Compare October 20, 2024 19:41
@DonIsaac DonIsaac force-pushed the don/10-20-docs_codegen_add_warn_missing_docs_to_oxc_codegen_ branch from 5d610b4 to 57c1313 Compare October 20, 2024 19:41
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 20, 2024

CodSpeed Performance Report

Merging #6711 will create unknown performance changes

Comparing don/10-20-docs_codegen_add_warn_missing_docs_to_oxc_codegen_ (374b972) with main (34b6221)

Summary

🆕 30 new benchmarks

Benchmarks breakdown

Benchmark main don/10-20-docs_codegen_add_warn_missing_docs_to_oxc_codegen_ Change
🆕 codegen[checker.ts] N/A 27.1 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 80 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 398.1 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 24.1 µs N/A
🆕 lexer[antd.js] N/A 22.4 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.5 ms N/A
🆕 lexer[checker.ts] N/A 13.3 ms N/A
🆕 lexer[pdf.mjs] N/A 3.6 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 3.3 ms N/A
🆕 linter[cal.com.tsx] N/A 1.4 s N/A
🆕 linter[checker.ts] N/A 2.5 s N/A
🆕 minifier[antd.js] N/A 426.4 ms N/A
🆕 minifier[react.development.js] N/A 2.9 ms N/A
🆕 minifier[typescript.js] N/A 520.3 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 78.2 µs N/A
🆕 parser[antd.js] N/A 107.5 ms N/A
🆕 parser[cal.com.tsx] N/A 24.7 ms N/A
🆕 parser[checker.ts] N/A 53.5 ms N/A
🆕 parser[pdf.mjs] N/A 17.5 ms N/A
🆕 semantic[RadixUIAdoptionSection.jsx] N/A 99 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@DonIsaac DonIsaac added the 0-merge Merge with Graphite Merge Queue label Oct 21, 2024
@DonIsaac DonIsaac force-pushed the don/10-20-doc_macros_add_warn_missing_docs_to_oxc_macros_ branch from 5eedc3d to 34b6221 Compare October 21, 2024 00:09
Copy link
Contributor Author

DonIsaac commented Oct 21, 2024

Merge activity

  • Oct 20, 8:09 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 20, 8:10 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 20, 8:22 PM EDT: A user merged this pull request with the Graphite merge queue.

Base automatically changed from don/10-20-doc_macros_add_warn_missing_docs_to_oxc_macros_ to main October 21, 2024 00:13
@DonIsaac DonIsaac force-pushed the don/10-20-docs_codegen_add_warn_missing_docs_to_oxc_codegen_ branch from 57c1313 to 374b972 Compare October 21, 2024 00:14
@graphite-app graphite-app bot merged commit 374b972 into main Oct 21, 2024
@graphite-app graphite-app bot deleted the don/10-20-docs_codegen_add_warn_missing_docs_to_oxc_codegen_ branch October 21, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-codegen Area - Code Generation C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants