Skip to content

docs(ast): enforce doc comments on JSX nodes, literal nodes, and comments#6712

Merged
graphite-app[bot] merged 1 commit intomainfrom
don/10-20-docs_ast_enforce_doc_comments_on_jsx_nodes_literal_nodes_and_comments
Oct 21, 2024
Merged

docs(ast): enforce doc comments on JSX nodes, literal nodes, and comments#6712
graphite-app[bot] merged 1 commit intomainfrom
don/10-20-docs_ast_enforce_doc_comments_on_jsx_nodes_literal_nodes_and_comments

Conversation

@DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Oct 20, 2024

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@DonIsaac DonIsaac marked this pull request as ready for review October 20, 2024 19:36
@github-actions github-actions bot added A-ast Area - AST C-docs Category - Documentation. Related to user-facing or internal documentation labels Oct 20, 2024
@DonIsaac DonIsaac force-pushed the don/10-20-docs_codegen_add_warn_missing_docs_to_oxc_codegen_ branch from 5d610b4 to 57c1313 Compare October 20, 2024 19:41
@DonIsaac DonIsaac force-pushed the don/10-20-docs_ast_enforce_doc_comments_on_jsx_nodes_literal_nodes_and_comments branch from 7238424 to 6cf53c6 Compare October 20, 2024 19:41
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 20, 2024

CodSpeed Performance Report

Merging #6712 will not alter performance

Comparing don/10-20-docs_ast_enforce_doc_comments_on_jsx_nodes_literal_nodes_and_comments (bad8770) with main (2e2b748)

Summary

✅ 30 untouched benchmarks

@DonIsaac DonIsaac force-pushed the don/10-20-docs_codegen_add_warn_missing_docs_to_oxc_codegen_ branch from 57c1313 to 374b972 Compare October 21, 2024 00:13
Base automatically changed from don/10-20-docs_codegen_add_warn_missing_docs_to_oxc_codegen_ to main October 21, 2024 00:22
@DonIsaac DonIsaac force-pushed the don/10-20-docs_ast_enforce_doc_comments_on_jsx_nodes_literal_nodes_and_comments branch from 6cf53c6 to 99c74fc Compare October 21, 2024 00:22
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 21, 2024 — with Graphite App
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 21, 2024

Merge activity

@Boshen Boshen force-pushed the don/10-20-docs_ast_enforce_doc_comments_on_jsx_nodes_literal_nodes_and_comments branch from 99c74fc to bad8770 Compare October 21, 2024 02:08
@graphite-app graphite-app bot merged commit bad8770 into main Oct 21, 2024
@graphite-app graphite-app bot deleted the don/10-20-docs_ast_enforce_doc_comments_on_jsx_nodes_literal_nodes_and_comments branch October 21, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants