Skip to content

refactor(traverse): change generate_uid_in_based_on_node to accept a generic type parameter as node type#6708

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-21-refactor_traverse_change_generate_uid_in_based_on_node_to_accept_a_generic_type_parameter_as_node_type
Oct 21, 2024
Merged

refactor(traverse): change generate_uid_in_based_on_node to accept a generic type parameter as node type#6708
graphite-app[bot] merged 1 commit intomainfrom
10-21-refactor_traverse_change_generate_uid_in_based_on_node_to_accept_a_generic_type_parameter_as_node_type

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Oct 20, 2024

Not only the Expression can be used to generate a binding name, but as long as AST that implements GatherNodeParts trait can do

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Oct 20, 2024
Copy link
Member Author

Dunqing commented Oct 20, 2024

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 20, 2024

CodSpeed Performance Report

Merging #6708 will not alter performance

Comparing 10-21-refactor_traverse_change_generate_uid_in_based_on_node_to_accept_a_generic_type_parameter_as_node_type (1370c2d) with main (d6609e9)

Summary

✅ 30 untouched benchmarks

@Dunqing Dunqing changed the title refactor(traverse): change generate_uid_in_based_on_node to accept a generic type parameter as node type refactor(traverse): change generate_uid_in_based_on_node to accept a generic type parameter as node type Oct 21, 2024
@Dunqing Dunqing requested a review from overlookmotel October 21, 2024 01:55
@Dunqing Dunqing marked this pull request as ready for review October 21, 2024 01:56
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 21, 2024 — with Graphite App
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 21, 2024

Merge activity

Boshen pushed a commit that referenced this pull request Oct 21, 2024
…a generic type parameter as node type (#6708)

Not only the `Expression` can be used to generate a binding name, but as long as AST that implements `GatherNodeParts` trait can do
@Boshen Boshen force-pushed the 10-21-refactor_traverse_change_generate_uid_in_based_on_node_to_accept_a_generic_type_parameter_as_node_type branch from ed15664 to 69786d6 Compare October 21, 2024 03:01
…a generic type parameter as node type (#6708)

Not only the `Expression` can be used to generate a binding name, but as long as AST that implements `GatherNodeParts` trait can do
@Boshen Boshen force-pushed the 10-21-refactor_traverse_change_generate_uid_in_based_on_node_to_accept_a_generic_type_parameter_as_node_type branch from 69786d6 to 1370c2d Compare October 21, 2024 03:03
@graphite-app graphite-app bot merged commit 1370c2d into main Oct 21, 2024
@graphite-app graphite-app bot deleted the 10-21-refactor_traverse_change_generate_uid_in_based_on_node_to_accept_a_generic_type_parameter_as_node_type branch October 21, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants