Skip to content

Comments

refactor(ast): change plain_function to accept FunctionBody as a required parameter#6709

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-21-refactor_ast_change_plain_function_to_accept_functionbody_as_a_required_parameter
Oct 21, 2024
Merged

refactor(ast): change plain_function to accept FunctionBody as a required parameter#6709
graphite-app[bot] merged 1 commit intomainfrom
10-21-refactor_ast_change_plain_function_to_accept_functionbody_as_a_required_parameter

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Oct 20, 2024

The plain_function method is used to construct js-only AST, and the FunctionBody is never empty in js

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Dunqing commented Oct 20, 2024

@github-actions github-actions bot added A-ast Area - AST A-transformer Area - Transformer / Transpiler labels Oct 20, 2024
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Oct 20, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 20, 2024

CodSpeed Performance Report

Merging #6709 will not alter performance

Comparing 10-21-refactor_ast_change_plain_function_to_accept_functionbody_as_a_required_parameter (0e9b695) with main (d6609e9)

Summary

✅ 30 untouched benchmarks

@Dunqing Dunqing changed the title refactor(ast): change plain_function to accept FunctionBody as a required parameter refactor(ast): change plain_function to accept FunctionBody as a required parameter Oct 21, 2024
@Dunqing Dunqing marked this pull request as ready for review October 21, 2024 01:51
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 21, 2024
Copy link
Member

Boshen commented Oct 21, 2024

Merge activity

  • Oct 20, 10:55 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 20, 10:55 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 20, 11:16 PM EDT: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 10-21-refactor_traverse_change_generate_uid_in_based_on_node_to_accept_a_generic_type_parameter_as_node_type branch from ed15664 to 69786d6 Compare October 21, 2024 03:01
Boshen pushed a commit that referenced this pull request Oct 21, 2024
…required parameter (#6709)

The `plain_function` method is used to construct js-only AST, and the `FunctionBody` is never empty in js
@Boshen Boshen force-pushed the 10-21-refactor_ast_change_plain_function_to_accept_functionbody_as_a_required_parameter branch from 645ff26 to 4bdb409 Compare October 21, 2024 03:01
…required parameter (#6709)

The `plain_function` method is used to construct js-only AST, and the `FunctionBody` is never empty in js
@Boshen Boshen force-pushed the 10-21-refactor_traverse_change_generate_uid_in_based_on_node_to_accept_a_generic_type_parameter_as_node_type branch from 69786d6 to 1370c2d Compare October 21, 2024 03:03
@Boshen Boshen force-pushed the 10-21-refactor_ast_change_plain_function_to_accept_functionbody_as_a_required_parameter branch from 4bdb409 to 0e9b695 Compare October 21, 2024 03:04
Base automatically changed from 10-21-refactor_traverse_change_generate_uid_in_based_on_node_to_accept_a_generic_type_parameter_as_node_type to main October 21, 2024 03:11
@graphite-app graphite-app bot merged commit 0e9b695 into main Oct 21, 2024
@graphite-app graphite-app bot deleted the 10-21-refactor_ast_change_plain_function_to_accept_functionbody_as_a_required_parameter branch October 21, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants