Skip to content

refactor(traverse): change generate_uid_in_based_on_node to accept a generic type parameter as node type #6708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Oct 21, 2024
Merged

refactor(traverse): change generate_uid_in_based_on_node to accept a generic type parameter as node type #6708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/oxc_traverse/src/ast_operations/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
mod gather_node_parts;
pub use self::gather_node_parts::get_var_name_from_node;
pub use self::gather_node_parts::{get_var_name_from_node, GatherNodeParts};
mod identifier;
pub use identifier::to_identifier;
10 changes: 5 additions & 5 deletions crates/oxc_traverse/src/context/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ use oxc_syntax::{

use crate::{
ancestor::{Ancestor, AncestorType},
ast_operations::get_var_name_from_node,
ast_operations::{get_var_name_from_node, GatherNodeParts},
};

mod ancestry;
Expand Down Expand Up @@ -352,9 +352,9 @@ impl<'a> TraverseCtx<'a> {
/// Based on Babel's `scope.generateUidBasedOnNode` logic.
/// <https://github.com/babel/babel/blob/419644f27c5c59deb19e71aaabd417a3bc5483ca/packages/babel-traverse/src/scope/index.ts#L543>
#[inline]
pub fn generate_uid_based_on_node(
pub fn generate_uid_based_on_node<N: GatherNodeParts<'a>>(
&mut self,
node: &Expression<'a>,
node: &N,
scope_id: ScopeId,
flags: SymbolFlags,
) -> BoundIdentifier<'a> {
Expand All @@ -367,9 +367,9 @@ impl<'a> TraverseCtx<'a> {
/// See also comments on [`TraverseScoping::generate_uid_name`] for important information
/// on how UIDs are generated. There are some potential "gotchas".
#[inline]
pub fn generate_uid_in_current_scope_based_on_node(
pub fn generate_uid_in_current_scope_based_on_node<N: GatherNodeParts<'a>>(
&mut self,
node: &Expression<'a>,
node: &N,
flags: SymbolFlags,
) -> BoundIdentifier<'a> {
self.generate_uid_based_on_node(node, self.current_scope_id(), flags)
Expand Down