Merged
Conversation
Member
Author
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
github-actions
bot
added
A-linter
Member
Author
CodSpeed Performance ReportMerging #2509 will not alter performanceComparing Summary
|
magic-akari
reviewed
Feb 26, 2024
| } | ||
| /// Enum Body | ||
| /// | ||
| /// A scope must be created on the enum body so this abstraction exists |
Member
Author
There was a problem hiding this comment.
I inlined enter / leave scope into the visitor function for now.
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/oxc
that referenced
this pull request
May 29, 2024
This was referenced Mar 25, 2025
overlookmotel
pushed a commit
that referenced
this pull request
Apr 3, 2025
Part of #9705 This PR fixes AST structure of `TSEnumDeclaration` from: ```js { "type": "TSEnumDeclaration", "id": { /* ... */ }, "members": [ { "type": "TSEnumMember", "id": { /* ... */ }, "initializer": null } ], "const": false, "declare": false } ``` to: ```js { "type": "TSEnumDeclaration", "id": { /* ... */ }, "body": { "type": "TSEnumBody", "members": [ { "type": "TSEnumMember", "id": { /* ... */ }, "initializer": null } ], }, "const": false, "declare": false } ``` > https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/ast-spec/src/declaration/TSEnumDeclaration/spec.ts > https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/ast-spec/src/special/TSEnumBody/spec.ts Historically, we had this node in the past, but it seems to have been deleted in #2509 . --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
overlookmotel
pushed a commit
that referenced
this pull request
Apr 9, 2025
Fixes #10087 --- Follow up for #10017 . This PR eliminates the part where nodes were manually generated for JS-land AST. NOTE: This node was originally present, but was removed at #2509 and is now being reintroduced to get the correct `Span` position for #9705 . --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.