feat(ast)!: Re-introduce TSEnumBody AST node#10284
Merged
overlookmotel merged 4 commits intomainfrom Apr 9, 2025
Merged
Conversation
github-actions
bot
added
A-linter
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
CodSpeed Instrumentation Performance ReportMerging #10284 will not alter performanceComparing Summary
|
Member
Author
🙆🏻 Thanks as always for your thoughtful review~! |
Member
Member
Dunqing
approved these changes
Apr 9, 2025
github-actions
bot
added
A-cli
overlookmotel
force-pushed
the
ast/tsenumbody
branch
from
2c8a55c to
d9444f1
Compare
overlookmotel
force-pushed
the
ast/tsenumbody
branch
from
d9444f1 to
135297b
Compare
Member
|
Boshen says no need for Have rebased on latest main and fixed conflicts. Will merge once CI passes. |
This was referenced Apr 14, 2025
Boshen
added a commit
that referenced
this pull request
Jan 16, 2026
Move `scope_id: Cell<Option<ScopeId>>` from `TSEnumDeclaration` to `TSEnumBody` for better semantic alignment. Since `TSEnumBody` was introduced as a dedicated type in PR #10284, the scope logically belongs on the body rather than on the parent declaration node. Closes #10331 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
3 tasks
graphite-app bot
pushed a commit
that referenced
this pull request
Jan 16, 2026
## Summary - Move `scope_id: Cell<Option<ScopeId>>` from `TSEnumDeclaration` to `TSEnumBody` - Since `TSEnumBody` was introduced as a dedicated type in PR #10284, the scope logically belongs on the body rather than on the parent declaration node Closes #10331 ## Test plan - [x] Unit tests pass (`just test`) - [x] Conformance tests pass (`just conformance`) - [x] Updated semantic test snapshots reflect scope now on `TSEnumBody` 🤖 Generated with [Claude Code](https://claude.ai/code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10087
Follow up for #10017 .
This PR eliminates the part where nodes were manually generated for JS-land AST.
NOTE: This node was originally present, but was removed at #2509 and is now being reintroduced to get the correct
Spanposition for #9705 .