fix(ast/estree): Add TSEnumBody to TSEnumDeclaration.body#10017
fix(ast/estree): Add TSEnumBody to TSEnumDeclaration.body#10017overlookmotel merged 14 commits intomainfrom
TSEnumBody to TSEnumDeclaration.body#10017Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
TSEnumBody to TSEnumDeclaration.body
CodSpeed Instrumentation Performance ReportMerging #10017 will degrade performances by 3.74%Comparing Summary
Benchmarks breakdown
|
|
This change causes many tests to pass, but I've just realized that this implementation may not be sufficient... I believe it might not work for code like this. enum Foo { A }
// ^^^^^^^I'm not sure how to handle these gaps in serialize step. Do we need to revive the |
Yes, we'll probably need to alter the Rust AST so it includes the But this PR already makes more tests pass, so let's get it merged, and we can then improve on it. |
|
@overlookmotel Thanks for the review~! I think I've fixed your points.
🫡 I will create another issue for this later. => #10087 |
|
Thank you! |
Fixes #10087 --- Follow up for #10017 . This PR eliminates the part where nodes were manually generated for JS-land AST. NOTE: This node was originally present, but was removed at #2509 and is now being reintroduced to get the correct `Span` position for #9705 . --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Part of #9705
This PR fixes AST structure of
TSEnumDeclarationfrom:to:
Historically, we had this node in the past, but it seems to have been deleted in #2509 .