perf(parser): remove a lookahead from eat_modifiers_before_declaration

[overlookmotel]

Remove an unnecessary lookahead from eat_modifiers_before_declaration. The loop below already does this check. There's no point doing it twice, especially as lookaheads aren't so cheap.

[overlookmotel]

• perf(parser): defer calculation of Modifier spans #20823 : 2 dependent PRs (#20824 , #20826 )
• perf(parser): remove branch from parse_modifiers #20821
• perf(parser): reduce Kind to ModifierKind conversions in eat_modifiers_before_declaration #20820
• refactor(parser): shorten code handling illegal modifiers #20781
• perf(parser): fast path for no syntax errors when checking modifiers #20748
• perf(parser): remove a lookahead from eat_modifiers_before_declaration #20755 👈 (View in Graphite)
• refactor(parser): nest modifiers types in modules #20754
• refactor(parser): re-order modifiers code #20753
• perf(parser): store Modifiers on stack #20742
• perf(parser): add Modifiers::get method #20741
• refactor(parser): rename ModifierKinds::empty to none #20740
• refactor(parser): rename ModifierFlags to ModifierKinds #20739
• refactor(parser): simplify ModifierFlags #20738
• refactor(parser): import from std at top level #20737
• refactor(parser): remove Modifier::is_static() #20736
• refactor(parser): remove dead code from modifier parsing #20735
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 8 skipped benchmarks¹

---

_{Comparing om/03-25-perf_parser_remove_a_lookahead_from_eat_modifiers_before_declaration_ (4e8b817) with main (d8e9d01)²}

Footnotes

1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

2. No successful run was found on main (4e8b817) during the generation of this report, so d8e9d01 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[Copilot]

Pull request overview

This PR removes a redundant modifier lookahead in the parser’s eat_modifiers_before_declaration, relying on the existing while self.at_modifier() loop condition to avoid doing the same lookahead twice.

Changes:

• Removed an early at_modifier() check/return in eat_modifiers_before_declaration to eliminate duplicate lookahead work.

[graphite-app]

Merge activity

• Mar 26, 1:13 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Mar 26, 1:13 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #20739.
• Mar 26, 1:13 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #20739.
• Mar 26, 1:28 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Mar 26, 1:29 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Mar 26, 1:33 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #20740.
• Mar 26, 1:33 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #20740.
• Mar 26, 1:33 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Mar 26, 1:34 PM UTC: The merge label '0-merge' was removed. This PR will no longer be merged by the Graphite merge queue
• Mar 26, 1:36 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Mar 26, 1:37 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Mar 26, 1:52 PM UTC: Merged by the Graphite merge queue.